Add deserialize method to Trigger base class and annotate classes dict (#596)

* Add deserialize method to Trigger base class and annotate classes dict

The classes dict in decode_trigger was inferred as dict[str, type] by
mypy, causing "type has no attribute deserialize" error. Add a type
annotation and a base class deserialize method to fix this.

* Add tests for Trigger.deserialize and decode_trigger

Author: mkusaka

api/library/python/iterm2/iterm2/triggers.py

@@ -37,7 +37,7 @@ def decode_trigger(encoded: dict) -> 'Trigger':
 
     :returns: A :class:`~Trigger`.
     """
-    classes = {
+    classes: typing.Dict[str, typing.Type[Trigger]] = {
         AlertTrigger._name(): AlertTrigger,
         AnnotateTrigger._name(): AnnotateTrigger,
         BellTrigger._name(): BellTrigger,
@@ -136,6 +136,10 @@ def enabled(self) -> bool:
     def enabled(self, value: bool):
         self.__enabled = value
 
+    @staticmethod
+    def deserialize(regex: str, param: str, instant: bool, enabled: bool) -> 'Trigger':
+        return Trigger(regex, param, instant, enabled)
+
     @property
     def encode(self) -> dict:
         return { "regex":  self.regex,

api/library/python/iterm2/tests/test_triggers.py

@@ -0,0 +1,77 @@
+"""Tests for iterm2.triggers module."""
+from iterm2.triggers import (
+    Trigger,
+    AlertTrigger,
+    BellTrigger,
+    HighlightTrigger,
+    decode_trigger,
+)
+
+
+class TestTriggerDeserialize:
+    """Tests for the Trigger base class deserialize method."""
+
+    def test_returns_trigger_instance(self):
+        """Test that Trigger.deserialize returns a Trigger instance."""
+        trigger = Trigger.deserialize("regex", "param", True, False)
+        assert isinstance(trigger, Trigger)
+
+    def test_fields_are_set(self):
+        """Test that deserialize sets all fields correctly."""
+        trigger = Trigger.deserialize("pattern", "value", False, True)
+        assert trigger.regex == "pattern"
+        assert trigger.param == "value"
+        assert trigger.instant is False
+        assert trigger.enabled is True
+
+
+class TestDecodeTrigger:
+    """Tests for decode_trigger using the classes dict and deserialize."""
+
+    def test_decode_known_trigger(self):
+        """Test decoding a known trigger type calls its deserialize."""
+        encoded = {
+            "action": "AlertTrigger",
+            "regex": "error",
+            "parameter": "Alert!",
+            "partial": False,
+            "disabled": False,
+        }
+        trigger = decode_trigger(encoded)
+        assert isinstance(trigger, AlertTrigger)
+        assert trigger.regex == "error"
+        assert trigger.instant is False
+        assert trigger.enabled is True
+
+    def test_decode_unknown_trigger_falls_back_to_base(self):
+        """Test that an unknown action falls back to Trigger.deserialize."""
+        encoded = {
+            "action": "SomeFutureTrigger",
+            "regex": "test",
+            "parameter": "param_value",
+        }
+        trigger = decode_trigger(encoded)
+        assert type(trigger) is Trigger
+        assert trigger.regex == "test"
+        assert trigger.param == "param_value"
+
+    def test_decode_defaults(self):
+        """Test that missing optional fields get default values."""
+        encoded = {
+            "action": "BellTrigger",
+            "regex": "bell",
+        }
+        trigger = decode_trigger(encoded)
+        assert isinstance(trigger, BellTrigger)
+        assert trigger.instant is False
+        assert trigger.enabled is True
+
+    def test_decode_disabled(self):
+        """Test that disabled flag is correctly inverted."""
+        encoded = {
+            "action": "BellTrigger",
+            "regex": "bell",
+            "disabled": True,
+        }
+        trigger = decode_trigger(encoded)
+        assert trigger.enabled is False