Skip to content

Commit 9f982ff

Browse files
PanyushkinDPanyushkinD
authored andcommitted
Fix tests for EFCore 2.0
1 parent f1e5167 commit 9f982ff

File tree

5 files changed

+19
-11
lines changed

5 files changed

+19
-11
lines changed

EFCore.CommonTools.Tests/Specification/SpecificationExpanderTests.cs

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,16 +39,17 @@ public void ShouldBeExpandedInExpressionTree()
3939

4040
var query = context.Users
4141
.AsVisitable(new SpecificationExpander())
42-
.Select(u => u.Posts.Where(postSpec));
42+
.Select(u => u.Posts.Where(postSpec).ToList());
4343

4444
var expected = context.Users
45-
.Select(u => u.Posts.Where(p => !p.IsDeleted));
45+
.Select(u => u.Posts.Where(p => !p.IsDeleted).ToList());
4646

4747
Assert.AreEqual(expected.ToString(), query.ToString());
4848

4949
Assert.That.MethodCallsAreMatch(expected.Expression, query.Expression);
5050

51-
Assert.IsNotNull(query.Single());
51+
// assert that we find one user with one post
52+
query.Single().Single();
5253
}
5354
}
5455

@@ -146,16 +147,23 @@ public void ShouldSupportConditionalLogicInExpressionTree()
146147

147148
var query = context.Users
148149
.AsVisitable(new SpecificationExpander())
149-
.Select(u => u.Posts.Where(new PostByContentSpec(content) || new PostByContentSpec(content)));
150+
.Select(u => u.Posts
151+
.Where(new PostByContentSpec(content)
152+
|| new PostByContentSpec(content))
153+
.ToList());
150154

151155
var expected = context.Users
152-
.Select(u => u.Posts.Where(p => p.Content.Contains(content) || p.Content.Contains(content)));
156+
.Select(u => u.Posts
157+
.Where(p => p.Content.Contains(content)
158+
|| p.Content.Contains(content))
159+
.ToList());
153160

154161
Assert.AreEqual(expected.ToString(), query.ToString());
155162

156163
Assert.That.MethodCallsAreMatch(expected.Expression, query.Expression);
157164

158-
Assert.IsNotNull(query.Single());
165+
// assert that we find one user with one post
166+
query.Single().Single();
159167
}
160168
}
161169

EFCore.CommonTools.Tests/TestDbContext.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
using System.Threading.Tasks;
33
using Microsoft.Data.Sqlite;
44
using Microsoft.EntityFrameworkCore;
5-
using Microsoft.EntityFrameworkCore.Infrastructure;
5+
using Microsoft.EntityFrameworkCore.Diagnostics;
66

77
namespace EntityFrameworkCore.CommonTools.Tests
88
{

EFCore.CommonTools/EntityFrameworkCore.CommonTools.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<RepositoryUrl>https://github.com/gnaeus/EntityFramework.CommonTools.git</RepositoryUrl>
1414
<RepositoryType>git</RepositoryType>
1515
<PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
16-
<PackageReleaseNotes>EFCore v2; Improve AuditableEntities API</PackageReleaseNotes>
16+
<PackageReleaseNotes>EFCore 2.0; Improve AuditableEntities API</PackageReleaseNotes>
1717
<Copyright>Copyright © Dmitry Panyushkin 2017</Copyright>
1818
<PackageTags>EF EFCore EntityFrameworkCore EntityFramework Entity Framework ChangeTracking Change Tracking Auditing Audit TransactionLog Transaction Log ComplexType Complex Type JSON</PackageTags>
1919
<GeneratePackageOnBuild>True</GeneratePackageOnBuild>

EntityFramework.CommonTools/EntityFramework.CommonTools.nuspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<licenseUrl>https://github.com/gnaeus/EntityFramework.CommonTools/blob/master/LICENSE</licenseUrl>
1212
<iconUrl>https://raw.githubusercontent.com/gnaeus/EntityFramework.CommonTools/master/icon.png</iconUrl>
1313
<requireLicenseAcceptance>false</requireLicenseAcceptance>
14-
<releaseNotes>EntityFramework v6.2; Improve AuditableEntities API</releaseNotes>
14+
<releaseNotes>EntityFramework 6.2; Improve AuditableEntities API</releaseNotes>
1515
<copyright>Copyright © Dmitry Panyushkin 2017</copyright>
1616
<tags>EF EntityFramework Entity Framework ChangeTracking Change Tracking Auditing Audit TransactionLog Transaction Log ComplexType Complex Type JSON</tags>
1717
<dependencies>

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -818,8 +818,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
818818

819819
## [2.0.0] - 2018-03-23
820820
### Added
821-
- EFCore v2 support
822-
- EntityFramework v6.2 support
821+
- EFCore 2.0 support
822+
- EntityFramework 6.2 support
823823

824824
### Changed
825825
- `ICreationAuditable.CreatorUser` renamed to `CreatorUserId`

0 commit comments

Comments
 (0)