Make download size checks more permissive to rely on checksums

- Reduce Node.js minimum size from 15MB to 1MB (fixes Node.js 4.2.0 download)
- Reduce Java minimum size from 100MB to 10MB for better compatibility
- Reduce default minimum size from 1MB to 100KB
- Size checks were causing false failures when checksums provide better validation
- Checksums detect any corruption while size checks can have false positives
- Magic byte validation already catches format issues (HTML, JSON responses)

This fixes CI failures where older Node.js versions are smaller than expected.

Author: gnodet

pkg/tools/base_tool.go

@@ -389,8 +389,8 @@ func (b *BaseTool) GetDefaultDownloadOptions() DownloadOptions {
 	return DownloadOptions{
 		FileExtension: ".tar.gz",
 		ExpectedType:  "application",
-		MinSize:       1 * 1024 * 1024,   // 1MB
-		MaxSize:       100 * 1024 * 1024, // 100MB
+		MinSize:       100 * 1024,        // 100KB (very permissive, rely on checksums)
+		MaxSize:       500 * 1024 * 1024, // 500MB (generous upper bound)
 		ArchiveType:   "tar.gz",
 	}
 }

pkg/tools/constants.go

@@ -4,8 +4,8 @@ import "time"
 
 // Download Configuration Constants
 const (
-	// File size limits
-	DefaultMinFileSize = 1024       // 1KB minimum file size
+	// File size limits - very permissive since we rely on checksums for validation
+	DefaultMinFileSize = 1024       // 1KB minimum file size (just to catch empty files)
 	DefaultMaxFileSize = 2147483648 // 2GB maximum file size
 
 	// Timeout defaults

pkg/tools/java.go

@@ -409,8 +409,8 @@ func (j *JavaTool) GetDownloadOptions() DownloadOptions {
 	return DownloadOptions{
 		FileExtension: ".tar.gz",
 		ExpectedType:  "application",
-		MinSize:       100 * 1024 * 1024, // 100MB
-		MaxSize:       500 * 1024 * 1024, // 500MB
+		MinSize:       10 * 1024 * 1024,  // 10MB (very permissive, rely on checksums)
+		MaxSize:       800 * 1024 * 1024, // 800MB (generous upper bound)
 		ArchiveType:   "tar.gz",
 	}
 }

pkg/tools/node.go

@@ -77,8 +77,8 @@ func (n *NodeTool) GetDownloadOptions() DownloadOptions {
 	return DownloadOptions{
 		FileExtension: ".tar.xz",
 		ExpectedType:  "application",
-		MinSize:       15 * 1024 * 1024, // 15MB (Node.js 18.17.0 is ~19.5MB)
-		MaxSize:       80 * 1024 * 1024, // 80MB
+		MinSize:       1 * 1024 * 1024,   // 1MB (very permissive, rely on checksums)
+		MaxSize:       200 * 1024 * 1024, // 200MB (generous upper bound)
 		ArchiveType:   "tar.xz",
 	}
 }