Severity: Informational

Description

Two functions in machine.go have confusing names that suggest they always pop frames, but they only pop when the target is found.

1. PopUntilLastCallFrame() (line 2172)

What the name suggests: Always pops frames while searching

What it actually does:

• If call frame found → pops frames and returns it
• If NOT found → doesn't pop anything, returns nil

2. PopUntilLastReviveFrame() (line 2184)

What the name suggests: Always pops frames while searching

What it actually does:

• If revive frame found → pops frames and returns it
• If NOT found → doesn't pop anything, returns nil

Locations

• gnovm/pkg/gnolang/machine.go lines 2172-2182, 2184-2193
• Used in op_call.go and other files