maint: use constexpr rather than static variable in cset 85bb7cdcfe3f.

Rik · Rik · commit 9c96772273db · 2025-08-06T22:35:37.000+02:00
* ls-oct-binary.cc (save_binary_data): Change static variable "max_dim_val" to
be a constexpr.
diff --git a/libinterp/corefcn/ls-oct-binary.cc b/libinterp/corefcn/ls-oct-binary.cc
@@ -341,7 +341,7 @@ save_binary_data (std::ostream& os, const octave_value& tc,
                   const std::string& name, const std::string& doc,
                   bool mark_global, bool save_as_floats)
 {
-  static octave_idx_type max_dim_val = std::numeric_limits<int32_t>::max () - 1;
+  constexpr octave_idx_type max_dim_val = std::numeric_limits<int32_t>::max () - 1;
 
   dim_vector dv = tc.dims ();
   if (dv.ndims () > max_dim_val)

Original file line number	Diff line number	Diff line change
`@@ -341,7 +341,7 @@ save_binary_data (std::ostream& os, const octave_value& tc,`
`341`	`341`	`const std::string& name, const std::string& doc,`
`342`	`342`	`bool mark_global, bool save_as_floats)`
`343`	`343`	`{`
`344`		`- static octave_idx_type max_dim_val = std::numeric_limits<int32_t>::max () - 1;`
	`344`	`+ constexpr octave_idx_type max_dim_val = std::numeric_limits<int32_t>::max () - 1;`
`345`	`345`
`346`	`346`	`dim_vector dv = tc.dims ();`
`347`	`347`	`if (dv.ndims () > max_dim_val)`