Update how we copy the resources

Author: gcasa

XCode/PBXResourcesBuildPhase.h

@@ -79,14 +79,6 @@
  */
 - (NSString *) generateInfoPlistOutput: (NSString *)outputPlist withIconFile: (NSString *)iconFile;
 
-/**
- * Converts build configuration to Info.plist dictionary.
- * Extracts relevant settings from the build configuration for plist generation.
- * Takes the build configuration to process as parameter.
- * Returns a mutable dictionary containing plist key-value pairs.
- */
-- (NSMutableDictionary *) configToInfoPlist: (XCBuildConfiguration *)config;
-
 /**
  * Converts build configuration to Info.plist dictionary with icon information.
  * Extracts settings and includes icon file reference in the generated dictionary.

XCode/PBXResourcesBuildPhase.m

@@ -79,7 +79,6 @@ - (NSString *) productName
 
 - (NSString *) discoverAppIcon
 {
-  NSFileManager *mgr = [NSFileManager defaultManager];
   NSString *filename = nil;
   NSString *productName = [_target name]; // [self productName];
   NSString *assetsDir = [productName stringByAppendingPathComponent: @"Assets.xcassets"];
@@ -184,7 +183,10 @@ - (BOOL) copyAppIconToResources: (NSString *)iconFilename
   // Debug output for paths
   xcputs([[NSString stringWithFormat: @"\t* Icon filename: '%@'", iconFilename] cString]);
   xcputs([[NSString stringWithFormat: @"\t* Source path: '%@'", imagePath] cString]);
-  xcputs([[NSString stringWithFormat: @"\t* Dest path: '%@'", destPath] cString]);
+  if (destPath != NULL && destPath != nil)
+    {
+      xcputs([[NSString stringWithFormat: @"\t* Dest path: '%@'", destPath] cString]);
+    }
 
   // Check if source file exists
   if (![mgr fileExistsAtPath: imagePath])
@@ -215,13 +217,22 @@ - (BOOL) copyAppIconToResources: (NSString *)iconFilename
     }
 
   // Copy the icon file
-  BOOL success = [mgr copyItemAtPath: imagePath
-			      toPath: destPath
-			       error: &error];
+  BOOL success = NO;
+  if (destPath != NULL && destPath != nil)
+    {
+      success = [mgr copyItemAtPath: imagePath
+			     toPath: destPath
+			      error: &error];
 
-  if (!success)
+      if (!success)
+	{
+	  xcputs([[NSString stringWithFormat: @"\t* ERROR: Failed to copy icon file: %@", error ? [error localizedDescription] : @"Unknown error"] cString]);
+	}
+    }
+  else
     {
-      xcputs([[NSString stringWithFormat: @"\t* ERROR: Failed to copy icon file: %@", error ? [error localizedDescription] : @"Unknown error"] cString]);
+      success = YES;
+      xcputs("\t* WARN: Not copying icon file, no destination provided");
     }
 
   return success;