Revert "Create a safe copy of the app icon"

This reverts commit 01f91a4.

Author: gcasa

Generators/Makefile/GSXCMakefileGenerator.m

@@ -75,10 +75,6 @@ - (BOOL) generate
   NSString *additionalIncludes = [self safeStringFromArray: [context objectForKey: @"ADDITIONAL_INCLUDE_DIRS"] withMethod: @selector(arrayToIncludeList)];
   NSString *additionalOCflags = [self safeStringFromArray: [context objectForKey: @"ADDITIONAL_OBJC_LIBS"] withMethod: @selector(arrayToLinkList)];
   NSString *projectType = [context objectForKey: @"PROJECT_TYPE"];
-  
-  // Get app icon information from build context
-  NSString *appIconFile = [context objectForKey: @"APP_ICON_FILE"];
-  NSString *safeAppIconFile = [context objectForKey: @"APP_ICON_SAFE_FILE"];
 
   // Debug output to see what we're getting from the context
   NSDebugLog(@"=== DEBUG: Makefile Generator Context ===");
@@ -88,8 +84,6 @@ - (BOOL) generate
   NSDebugLog(@"OBJCPP_FILES: %@", [context objectForKey: @"OBJCPP_FILES"]);
   NSDebugLog(@"RESOURCES: %@", [context objectForKey: @"RESOURCES"]);
   NSDebugLog(@"PROJECT_TYPE: %@", projectType);
-  NSDebugLog(@"APP_ICON_FILE: %@", appIconFile);
-  NSDebugLog(@"APP_ICON_SAFE_FILE: %@", safeAppIconFile);
   NSDebugLog(@"========================================");
 
   // Construct the makefile out of the data we have thusfar collected.
@@ -149,23 +143,6 @@ - (BOOL) generate
                                     [NSString stringWithFormat: @"%@_RESOURCE_FILES = %@\n\n", appName, resourceFilesString]];
     }
 
-  // Add app icon handling if an icon was discovered
-  if (appIconFile != nil && [projectType isEqualToString: @"application"])
-    {
-      NSString *iconToUse = safeAppIconFile ? safeAppIconFile : appIconFile;
-      makefileString = [makefileString stringByAppendingString: @"# App icon handling\n"];
-      makefileString = [makefileString stringByAppendingString: 
-                                    [NSString stringWithFormat: @"%@_MAIN_MODEL_FILE = %@\n", appName, iconToUse]];
-      
-      // Add a rule to copy the app icon to the app bundle
-      makefileString = [makefileString stringByAppendingString: @"# Copy app icon to Resources directory\n"];
-      makefileString = [makefileString stringByAppendingString: 
-                                    [NSString stringWithFormat: @"after-install::\n\t$(INSTALL_DATA) %@ $(GNUSTEP_APP_INSTALL_DIR)/%@.app/Resources/\n\n", 
-                                                               iconToUse, appName]];
-      
-      xcputs([[NSString stringWithFormat: @"\t* Added app icon to makefile: %@", iconToUse] cString]);
-    }
-  
   if ([additionalIncludes length] > 0)
     {
       makefileString = [makefileString stringByAppendingString:

XCode/PBXResourcesBuildPhase.h

@@ -55,14 +55,6 @@
  */
 - (BOOL) copyAppIconToResources: (NSString *)iconFilename;
 
-/**
- * Creates a safe copy of the app icon file with spaces replaced by underscores.
- * If the icon filename contains spaces, creates a copy with a makefile-safe name.
- * Takes the name of the icon file to process as parameter.
- * Returns the safe filename if a copy was created, or nil if no spaces were found.
- */
-- (NSString *) createSafeIconCopy: (NSString *)iconFilename;
-
 /**
  * Escapes special characters in filenames for makefile compatibility.
  * Handles spaces, dollar signs, hash symbols, and colons that have special 

XCode/PBXResourcesBuildPhase.m

@@ -238,46 +238,6 @@ - (BOOL) copyAppIconToResources: (NSString *)iconFilename
   return success;
 }
 
-- (NSString *) createSafeIconCopy: (NSString *)iconFilename
-{
-  if (iconFilename == nil || [iconFilename rangeOfString: @" "].location == NSNotFound)
-    {
-      // No spaces, return original filename
-      return nil;
-    }
-
-  NSFileManager *mgr = [NSFileManager defaultManager];
-  NSString *productName = [_target name];
-  NSString *assetsDir = [productName stringByAppendingPathComponent: @"Assets.xcassets"];
-  NSString *appIconDir = [assetsDir stringByAppendingPathComponent: @"AppIcon.appiconset"];
-  NSString *sourcePath = [appIconDir stringByAppendingPathComponent: iconFilename];
-  
-  // Create safe filename by replacing spaces with underscores
-  NSString *safeFilename = [iconFilename stringByReplacingOccurrencesOfString: @" " withString: @"_"];
-  NSString *safePath = [appIconDir stringByAppendingPathComponent: safeFilename];
-  
-  xcputs([[NSString stringWithFormat: @"\t* Creating safe icon copy: %@ -> %@", iconFilename, safeFilename] cString]);
-  
-  // Copy original to safe filename
-  NSError *error = nil;
-  if ([mgr fileExistsAtPath: safePath])
-    {
-      [mgr removeItemAtPath: safePath error: NULL];
-    }
-  
-  BOOL success = [mgr copyItemAtPath: sourcePath toPath: safePath error: &error];
-  if (success)
-    {
-      xcputs([[NSString stringWithFormat: @"\t* Successfully created safe icon copy: %@", safeFilename] cString]);
-      return safeFilename;
-    }
-  else
-    {
-      xcputs([[NSString stringWithFormat: @"\t* ERROR: Failed to create safe icon copy: %@", error ? [error localizedDescription] : @"Unknown error"] cString]);
-      return nil;
-    }
-}
-
 - (NSString *) processAssets
 {
   NSString *filename = [self discoverAppIcon];
@@ -665,32 +625,18 @@ - (BOOL) generate
   NSString *iconPath = [self discoverAppIconPath];
   xcputs([[NSString stringWithFormat: @"\t* Discovered app icon: %@", iconFile ? iconFile : @"(none)"] cString]);
 
-  // Store app icon information in build context for makefile generation
-  GSXCBuildContext *context = [GSXCBuildContext sharedBuildContext];
-  if (iconFile != nil)
-    {
-      [context setObject: iconFile forKey: @"APP_ICON_FILE"];
-      xcputs([[NSString stringWithFormat: @"\t* Stored app icon in build context: %@", iconFile] cString]);
-    }
-
   // Add icon file to resources if found
   if (iconPath != nil)
     {
       NSString *escapedIconPath = [self escapeFilenameForMakefile: iconPath];
       xcputs([[NSString stringWithFormat: @"\t* Adding app icon to resources: %@", iconPath] cString]);
       [resources addObject: escapedIconPath];
 
-      // Copy app icon to resources directory with safe filename
-      NSString *safeIconFile = [self createSafeIconCopy: iconFile];
-      BOOL iconCopied = [self copyAppIconToResources: safeIconFile ? safeIconFile : iconFile];
+      // Copy app icon to resources directory
+      BOOL iconCopied = [self copyAppIconToResources: iconFile];
       if (iconCopied)
         {
-          xcputs([[NSString stringWithFormat: @"\t* Copied app icon to resources: %@", safeIconFile ? safeIconFile : iconFile] cString]);
-          // Store the safe filename for makefile generation
-          if (safeIconFile != nil)
-            {
-              [context setObject: safeIconFile forKey: @"APP_ICON_SAFE_FILE"];
-            }
+          xcputs([[NSString stringWithFormat: @"\t* Copied app icon to resources: %@", iconFile] cString]);
         }
       else
         {