code organize with responbility elements

Author: jeevatkm

file_receiver.go

@@ -16,7 +16,12 @@ import (
 	"aahframework.org/essentials.v0"
 )
 
-var _ Receiver = &FileReceiver{}
+var (
+	// backupTimeFormat is used for timestamp with filename on rotation
+	backupTimeFormat = "2006-01-02-15-04-05.000"
+
+	_ Receiver = &FileReceiver{}
+)
 
 // FileReceiver writes the log entry into file.
 type FileReceiver struct {
@@ -193,7 +198,7 @@ func (f *FileReceiver) backupFileName() string {
 	if f.isUTC {
 		t = t.UTC()
 	}
-	return filepath.Join(dir, fmt.Sprintf("%s-%s%s", baseName, t.Format(BackupTimeFormat), ext))
+	return filepath.Join(dir, fmt.Sprintf("%s-%s%s", baseName, t.Format(backupTimeFormat), ext))
 }
 
 func (f *FileReceiver) getDay() int {

formatter.go

@@ -11,23 +11,70 @@ import (
 	"strings"
 )
 
+// Format flags used to define log message format for each log entry
+const (
+	FmtFlagLevel fmtFlag = iota
+	FmtFlagTime
+	FmtFlagUTCTime
+	FmtFlagLongfile
+	FmtFlagShortfile
+	FmtFlagLine
+	FmtFlagMessage
+	FmtFlagCustom
+	FmtFlagUnknown
+)
+
 const (
 	textFmt = "text"
 	jsonFmt = "json"
 )
 
-// FlagPart is indiviual flag details
-//  For e.g.:
-//    part := FlagPart{
-//      Flag:   fmtFlagTime,
-//      Name:   "time",
-//      Format: "2006-01-02 15:04:05.000",
-//    }
-type FlagPart struct {
-	Flag   fmtFlag
-	Name   string
-	Format string
-}
+type (
+	// FlagPart is indiviual flag details
+	//  For e.g.:
+	//    part := FlagPart{
+	//      Flag:   fmtFlagTime,
+	//      Name:   "time",
+	//      Format: "2006-01-02 15:04:05.000",
+	//    }
+	FlagPart struct {
+		Flag   fmtFlag
+		Name   string
+		Format string
+	}
+
+	// FmtFlag type definition
+	fmtFlag uint8
+)
+
+var (
+	// DefaultPattern is default log entry pattern in aah/log. Only applicable to
+	// text formatter.
+	// For e.g:
+	//    2006-01-02 15:04:05.000 INFO  This is my message
+	DefaultPattern = "%time:2006-01-02 15:04:05.000 %level:-5 %message"
+
+	// FmtFlags is the list of log format flags supported by aah/log library
+	// Usage of flag order is up to format composition.
+	//    level     - outputs INFO, DEBUG, ERROR, so on
+	//    time      - outputs local time as per format supplied
+	//    utctime   - outputs UTC time as per format supplied
+	//    longfile  - outputs full file name: /a/b/c/d.go
+	//    shortfile - outputs final file name element: d.go
+	//    line      - outputs file line number: L23
+	//    message   - outputs given message along supplied arguments if they present
+	//    custom    - outputs string as-is into log entry
+	FmtFlags = map[string]fmtFlag{
+		"level":     FmtFlagLevel,
+		"time":      FmtFlagTime,
+		"utctime":   FmtFlagUTCTime,
+		"longfile":  FmtFlagLongfile,
+		"shortfile": FmtFlagShortfile,
+		"line":      FmtFlagLine,
+		"message":   FmtFlagMessage,
+		"custom":    FmtFlagCustom,
+	}
+)
 
 //‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾
 // textFormatter

log.go

@@ -34,13 +34,8 @@ import (
 	"aahframework.org/config.v0"
 )
 
-type (
-	// FmtFlag type definition
-	fmtFlag uint8
-
-	// Level type definition
-	level uint8
-)
+// Level type definition
+type level uint8
 
 // Log Level definition
 const (
@@ -54,53 +49,10 @@ const (
 	LevelUnknown
 )
 
-// Format flags used to define log message format for each log entry
-const (
-	FmtFlagLevel fmtFlag = iota
-	FmtFlagTime
-	FmtFlagUTCTime
-	FmtFlagLongfile
-	FmtFlagShortfile
-	FmtFlagLine
-	FmtFlagMessage
-	FmtFlagCustom
-	FmtFlagUnknown
-)
-
 var (
 	// Version no. of aahframework.org/log library
 	Version = "0.5"
 
-	// FmtFlags is the list of log format flags supported by aah/log library
-	// Usage of flag order is up to format composition.
-	//    level     - outputs INFO, DEBUG, ERROR, so on
-	//    time      - outputs local time as per format supplied
-	//    utctime   - outputs UTC time as per format supplied
-	//    longfile  - outputs full file name: /a/b/c/d.go
-	//    shortfile - outputs final file name element: d.go
-	//    line      - outputs file line number: L23
-	//    message   - outputs given message along supplied arguments if they present
-	//    custom    - outputs string as-is into log entry
-	FmtFlags = map[string]fmtFlag{
-		"level":     FmtFlagLevel,
-		"time":      FmtFlagTime,
-		"utctime":   FmtFlagUTCTime,
-		"longfile":  FmtFlagLongfile,
-		"shortfile": FmtFlagShortfile,
-		"line":      FmtFlagLine,
-		"message":   FmtFlagMessage,
-		"custom":    FmtFlagCustom,
-	}
-
-	// DefaultPattern is default log entry pattern in aah/log. Only applicable to
-	// text formatter.
-	// For e.g:
-	//    2006-01-02 15:04:05.000 INFO  This is my message
-	DefaultPattern = "%time:2006-01-02 15:04:05.000 %level:-5 %message"
-
-	// BackupTimeFormat is used for timestamp with filename on rotation
-	BackupTimeFormat = "2006-01-02-15-04-05.000"
-
 	// ErrLogReceiverIsNil returned when suppiled receiver is nil.
 	ErrLogReceiverIsNil = errors.New("log: receiver is nil")