Skip to content

Commit f78044a

Browse files
committed
added Newc logger create method
1 parent 5e67669 commit f78044a

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

log.go

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ type Logger interface {
193193
Tracef(format string, v ...interface{})
194194
}
195195

196-
// New creates the logger based config supplied
196+
// New creates the aah logger based on supplied config string
197197
func New(configStr string) (Logger, error) {
198198
if ess.IsStrEmpty(configStr) {
199199
return nil, errors.New("logger config is empty")
@@ -204,6 +204,15 @@ func New(configStr string) (Logger, error) {
204204
return nil, err
205205
}
206206

207+
return Newc(cfg)
208+
}
209+
210+
// Newc creates the aah logger based on supplied `config.Config`
211+
func Newc(cfg *config.Config) (Logger, error) {
212+
if cfg == nil {
213+
return nil, errors.New("logger config is nil")
214+
}
215+
207216
receiverType, found := cfg.String("receiver")
208217
if !found {
209218
return nil, errors.New("receiver configuration is required")
@@ -290,7 +299,7 @@ func newConsoleReceiver(cfg *config.Config, receiverType string, level Level, fl
290299
func newFileReceiver(cfg *config.Config, receiverType string, level Level, flags *[]FlagPart) (*Receiver, error) {
291300
maxSize := cfg.IntDefault("rotate.size", 100)
292301
if maxSize > 2048 { // maximum 2GB file size
293-
return nil, errors.New("maximum 2GB file size supported for rotation")
302+
return nil, errors.New("max size > 2GB, please set it to 2048 for size rotation")
294303
}
295304

296305
receiver := Receiver{
@@ -311,8 +320,6 @@ func newFileReceiver(cfg *config.Config, receiverType string, level Level, flags
311320
}
312321

313322
receiver.rotate = cfg.StringDefault("rotate.mode", "daily")
314-
// rotate, _ := cfg.GetSection("rotate")
315-
// receiver.rotate, _ = rotate.GetString("mode")
316323
switch receiver.rotate {
317324
case "daily":
318325
receiver.setOpenDay()

0 commit comments

Comments
 (0)