Skip to content

Commit 895a953

Browse files
authored
feat: improve propagation check error messages (#2306)
1 parent ee445c0 commit 895a953

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

challenge/dns01/precheck.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ func (p preCheck) checkDNSPropagation(fqdn, value string) (bool, error) {
8686
// Initial attempt to resolve at the recursive NS (require to get CNAME)
8787
r, err := dnsQuery(fqdn, dns.TypeTXT, recursiveNameservers, true)
8888
if err != nil {
89-
return false, err
89+
return false, fmt.Errorf("initial recursive nameserver: %w", err)
9090
}
9191

9292
if r.Rcode == dns.RcodeSuccess {
@@ -96,7 +96,7 @@ func (p preCheck) checkDNSPropagation(fqdn, value string) (bool, error) {
9696
if p.requireRecursiveNssPropagation {
9797
_, err = checkNameserversPropagation(fqdn, value, recursiveNameservers, false)
9898
if err != nil {
99-
return false, err
99+
return false, fmt.Errorf("recursive nameservers: %w", err)
100100
}
101101
}
102102

@@ -109,7 +109,12 @@ func (p preCheck) checkDNSPropagation(fqdn, value string) (bool, error) {
109109
return false, err
110110
}
111111

112-
return checkNameserversPropagation(fqdn, value, authoritativeNss, true)
112+
found, err := checkNameserversPropagation(fqdn, value, authoritativeNss, true)
113+
if err != nil {
114+
return found, fmt.Errorf("authoritative nameservers: %w", err)
115+
}
116+
117+
return found, nil
113118
}
114119

115120
// checkNameserversPropagation queries each of the given nameservers for the expected TXT record.

0 commit comments

Comments
 (0)