Skip to content

Add DNS provider for United-Domains #2731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 27, 2025
Merged

Add DNS provider for United-Domains #2731

merged 3 commits into from
Nov 27, 2025
+476 −21

Conversation

@ldez
Copy link
Member

@ldez ldez commented Nov 26, 2025

Closes #2730

Ping @IONOS-Haefele, can you run the command (with your domain, email, credentials, etc.)?

make build
rm -rf .lego

UNITEDDOMAINS_API_KEY="xxx" \
lego --email [email protected] --dns uniteddomains -d '*.example.com' -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run

Note that the wildcard domain is important.

How to test this PR?
  1. You need Go
  2. Check out the PR: 
    git clone https://github.com/ldez/lego.git
cd lego
git checkout feat/dns/uniteddomains
  3. Compile lego:
    • if you have make: make build
    • if you don't have make: go build -o dist/lego ./cmd/lego
  4. Run the following command with your information (email, domain, credentials): 
    UNITEDDOMAINS_API_KEY="xxx" \
./dist/lego --email [email protected] --dns uniteddomains -d '*.example.com' -d example.com  -s https://acme-staging-v02.api.letsencrypt.org/directory run
    The wildcard domain is important
  5. Before each run of the command, you should clean your local environment: 
    rm -rf .lego

@ldez ldez added enhancement area/dnsprovider waiting-for/user-tests Need users to test functionality waiting-for/contrib-feedback Awaiting feedback from the contributor. labels Nov 26, 2025
@IONOS-Haefele
Copy link

IONOS-Haefele commented Nov 27, 2025 •
edited
Loading

Ping @ldez:

I can not do the test, but my colleague can ;-).

Result: It worked!

Here are the results:

UNITEDDOMAINS_API_KEY="d813e5cb6c584b0e891[...]" ./lego --email [[email protected]](mailto:[email protected]) --dns uniteddomains -d '*.ud-support-test.de' -d ud-support-test.de -s https://acme-staging-v02.api.letsencrypt.org/directory run
2025/11/27 09:07:47 No key found for account [[email protected]](mailto:[email protected]). Generating a P256 key.
2025/11/27 09:07:47 Saved key to /home/andreas01/test/lego/dist/.lego/accounts/acme-staging-v02.api.letsencrypt.org/[email protected]/keys/[email protected]
2025/11/27 09:07:47 Please review the TOS at https://letsencrypt.org/documents/LE-SA-v1.6-August-18-2025.pdf
Do you accept the TOS? Y/n
y
2025/11/27 09:07:56 [INFO] acme: Registering account for [[email protected]](mailto:[email protected])
!!!! HEADS UP !!!!

Your account credentials have been saved in your
configuration directory at "/home/andreas01/test/lego/dist/.lego/accounts".

You should make a secure backup of this folder now. This
configuration directory will also contain certificates and
private keys obtained from the ACME server so making regular
backups of this folder is ideal.
2025/11/27 09:07:56 [INFO] [*.ud-support-test.de, ud-support-test.de] acme: Obtaining bundled SAN certificate
2025/11/27 09:07:57 [INFO] [*.ud-support-test.de] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/246261283/20438746603
2025/11/27 09:07:57 [INFO] [ud-support-test.de] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/246261283/20438746613
2025/11/27 09:07:57 [INFO] [*.ud-support-test.de] acme: use dns-01 solver
2025/11/27 09:07:57 [INFO] [ud-support-test.de] acme: Could not find solver for: tls-alpn-01
2025/11/27 09:07:57 [INFO] [ud-support-test.de] acme: Could not find solver for: http-01
2025/11/27 09:07:57 [INFO] [ud-support-test.de] acme: use dns-01 solver
2025/11/27 09:07:57 [INFO] [*.ud-support-test.de] acme: Preparing to solve DNS-01
2025/11/27 09:07:58 [INFO] [ud-support-test.de] acme: Preparing to solve DNS-01
2025/11/27 09:08:00 [INFO] [*.ud-support-test.de] acme: Trying to solve DNS-01
2025/11/27 09:08:00 [INFO] [*.ud-support-test.de] acme: Checking DNS record propagation. [nameservers=127.0.0.53:53]
2025/11/27 09:08:02 [INFO] Wait for propagation [timeout: 15m0s, interval: 2s]
2025/11/27 09:08:06 [INFO] [*.ud-support-test.de] The server validated our request
2025/11/27 09:08:06 [INFO] [ud-support-test.de] acme: Trying to solve DNS-01
2025/11/27 09:08:06 [INFO] [ud-support-test.de] acme: Checking DNS record propagation. [nameservers=127.0.0.53:53]
2025/11/27 09:08:08 [INFO] Wait for propagation [timeout: 15m0s, interval: 2s]
2025/11/27 09:08:11 [INFO] [ud-support-test.de] The server validated our request
2025/11/27 09:08:11 [INFO] [*.ud-support-test.de] acme: Cleaning DNS-01 challenge
2025/11/27 09:08:12 [INFO] [ud-support-test.de] acme: Cleaning DNS-01 challenge
2025/11/27 09:08:13 [INFO] [*.ud-support-test.de, ud-support-test.de] acme: Validations succeeded; requesting certificates
2025/11/27 09:08:13 [INFO] Wait for certificate [timeout: 30s, interval: 500ms]
2025/11/27 09:08:14 [INFO] [*.ud-support-test.de] Server responded with a certificate.

@ldez ldez marked this pull request as ready for review November 27, 2025 11:43
@ldez ldez removed waiting-for/user-tests Need users to test functionality waiting-for/contrib-feedback Awaiting feedback from the contributor. labels Nov 27, 2025
@ldez ldez requested a review from dmke November 27, 2025 11:44
@ldez ldez added this to the unreleased milestone Nov 27, 2025
@ldez ldez merged commit dc0a595 into go-acme:master Nov 27, 2025
7 checks passed
@ldez ldez deleted the fix/dns/uniteddomains branch November 27, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmke dmke dmke approved these changes

Assignees

No one assigned

Labels

area/dnsprovider enhancement

Milestone

unreleased

Development

Successfully merging this pull request may close these issues.

Support for provider: united-domains

3 participants

@ldez @IONOS-Haefele @dmke