proc: rename ManualStopRequested to CheckAndClearManualStopRequest (#1119)

Author: aarzilli

pkg/proc/core/core.go

@@ -282,7 +282,7 @@ func (p *Process) RequestManualStop() error {
 	return nil
 }
 
-func (p *Process) ManualStopRequested() bool {
+func (p *Process) CheckAndClearManualStopRequest() bool {
 	return false
 }
 

pkg/proc/gdbserial/gdbserver.go

@@ -717,7 +717,7 @@ func (p *Process) RequestManualStop() error {
 	return p.conn.sendCtrlC()
 }
 
-func (p *Process) ManualStopRequested() bool {
+func (p *Process) CheckAndClearManualStopRequest() bool {
 	p.conn.manualStopMutex.Lock()
 	msr := p.manualStopRequested
 	p.manualStopRequested = false

pkg/proc/interface.go

@@ -87,9 +87,9 @@ type ProcessManipulation interface {
 	SwitchThread(int) error
 	SwitchGoroutine(int) error
 	RequestManualStop() error
-	// ManualStopRequested returns true the first time it's called after a call
-	// to RequestManualStop.
-	ManualStopRequested() bool
+	// CheckAndClearManualStopRequest returns true the first time it's called
+	// after a call to RequestManualStop.
+	CheckAndClearManualStopRequest() bool
 	Halt() error
 	Kill() error
 	Detach(bool) error

pkg/proc/native/proc.go

@@ -183,7 +183,7 @@ func (dbp *Process) RequestManualStop() error {
 	return dbp.requestManualStop()
 }
 
-func (dbp *Process) ManualStopRequested() bool {
+func (dbp *Process) CheckAndClearManualStopRequest() bool {
 	dbp.haltMu.Lock()
 	msr := dbp.manualStopRequested
 	dbp.manualStopRequested = false

pkg/proc/proc.go

@@ -87,9 +87,9 @@ func Continue(dbp Process) error {
 	if dbp.Exited() {
 		return &ProcessExitedError{Pid: dbp.Pid()}
 	}
-	dbp.ManualStopRequested()
+	dbp.CheckAndClearManualStopRequest()
 	for {
-		if dbp.ManualStopRequested() {
+		if dbp.CheckAndClearManualStopRequest() {
 			return nil
 		}
 		trapthread, err := dbp.ContinueOnce()