Skip to content

Commit 0d5f4f0

Browse files
author
Hongchao Deng
committed
nit: log error check
1 parent f991b1b commit 0d5f4f0

File tree

1 file changed

+12
-17
lines changed

1 file changed

+12
-17
lines changed

db/log/log.go

Lines changed: 12 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -16,36 +16,31 @@ func Create() (*Log, error) {
1616
if err != nil {
1717
return nil, err
1818
}
19-
2019
return &Log{f}, nil
2120
}
2221

2322
func (l *Log) Destroy() error {
2423
return os.Remove(l.f.Name())
2524
}
2625

27-
func (l *Log) GetRecord(offset int64) (*message.Record, error) {
28-
_, err := l.f.Seek(offset, 0)
29-
if err != nil {
30-
return nil, err
26+
func (l *Log) GetRecord(offset int64) (r *message.Record, err error) {
27+
if _, err = l.f.Seek(offset, 0); err != nil {
28+
return
3129
}
32-
3330
decoder := newDecoder(l.f)
34-
r := &message.Record{}
35-
decoder.decode(r)
36-
37-
return r, nil
31+
r = &message.Record{}
32+
err = decoder.decode(r)
33+
return
3834
}
3935

4036
func (l *Log) Append(r *message.Record) (offset int64, err error) {
41-
offset, err = l.f.Seek(0, 2)
42-
if err != nil {
43-
return -1, err
37+
if offset, err = l.f.Seek(0, 2); err != nil {
38+
return
4439
}
45-
4640
encoder := newEncoder(l.f)
47-
48-
err = encoder.encode(r)
49-
encoder.flush()
41+
if err = encoder.encode(r); err != nil {
42+
return
43+
}
44+
err = encoder.flush()
5045
return offset, err
5146
}

0 commit comments

Comments
 (0)