Skip to content

Commit b2448de

Browse files
author
Hongchao Deng
committed
clean up resources in test;
nit in io_test
1 parent 322f92f commit b2448de

File tree

1 file changed

+19
-9
lines changed

1 file changed

+19
-9
lines changed

db/recordio/io_test.go

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,37 +8,47 @@ import (
88
)
99

1010
func TestFetch(t *testing.T) {
11-
writeFile, err := ioutil.TempFile("", "backend")
11+
writeFile, err := ioutil.TempFile("", "testfetch")
1212
if err != nil {
1313
t.Error("can't create temp file")
1414
}
15+
defer os.Remove(writeFile.Name())
16+
defer writeFile.Close()
17+
1518
readFile, err := os.Open(writeFile.Name())
1619
if err != nil {
1720
t.Error("can't open temp file")
1821
}
22+
defer readFile.Close()
1923

2024
ap := NewAppender(writeFile)
2125
fc := NewFetcher(readFile)
2226

23-
tests := []Record{
24-
{[]byte("someData")},
25-
{[]byte("someOtherData")},
27+
tests := []struct {
28+
offset int64
29+
record Record
30+
}{
31+
{-1, Record{[]byte("someData")}},
32+
{-1, Record{[]byte("someOtherData")}},
2633
}
2734

28-
for i, recWrite := range tests {
29-
offset, err := ap.Append(recWrite)
35+
for i, tt := range tests {
36+
offset, err := ap.Append(tt.record)
3037
if err != nil {
3138
t.Errorf("#%d: Append failed: %s", i, err.Error())
3239
}
40+
tests[i].offset = offset
41+
}
3342

34-
recRead, err := fc.Fetch(offset)
43+
for i, tt := range tests {
44+
recRead, err := fc.Fetch(tt.offset)
3545
if err != nil {
3646
t.Errorf("#%d: Fetch failed: %s", i, err.Error())
3747
}
3848

39-
if !reflect.DeepEqual(recRead, recWrite) {
49+
if !reflect.DeepEqual(recRead, tt.record) {
4050
t.Errorf("#%d: records not the same, want: %v, get %v",
41-
i, recWrite, recRead)
51+
i, tt.offset, recRead)
4252
}
4353

4454
}

0 commit comments

Comments
 (0)