Skip to content

Fix issue#12 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix issue#12 #14

wants to merge 1 commit into from

Conversation

@yunxing
Copy link
Contributor

@yunxing yunxing commented Oct 9, 2014

  • Provide an interface for record so the client can provide its own implementation.
  • Add documentation to the exposed symbols in recordio.record
  • Change Appender and Fetcher to use the new interface

Refactor recordio.record
7bbf4af 
- Provide an interface for record so the client can provide its own implementation.
- Add documentation to the exposed symbols in recordio.record
- Change Appender and Fetcher to use the new interface
xiang90
xiang90 reviewed Oct 12, 2014
View reviewed changes
db/backend.go
Copy link
Contributor

@xiang90 xiang90 Oct 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rec := &recordio.Record{}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yunxing @xiang90