Merge pull request #66 from jfontan/fix/test-mkdirall

mcuadros · web-flow · commit 40f7491e8a4a · 2018-12-21T16:58:41.000+01:00
test: create directories with execution bit set
diff --git a/test/dir.go b/test/dir.go
@@ -86,7 +86,7 @@ func (s *DirSuite) TestMkdirAllWithExistingFile(c *C) {
 }
 
 func (s *DirSuite) TestStatDir(c *C) {
-	s.FS.MkdirAll("foo/bar", 0644)
+	s.FS.MkdirAll("foo/bar", 0755)
 
 	fi, err := s.FS.Stat("foo/bar")
 	c.Assert(err, IsNil)
@@ -164,7 +164,7 @@ func (s *DirSuite) TestReadDirNested(c *C) {
 }
 
 func (s *DirSuite) TestReadDirWithMkDirAll(c *C) {
-	err := s.FS.MkdirAll("qux", 0644)
+	err := s.FS.MkdirAll("qux", 0755)
 	c.Assert(err, IsNil)
 
 	files := []string{"qux/baz", "qux/qux"}
@@ -239,7 +239,7 @@ func (s *DirSuite) TestRenameToDir(c *C) {
 }
 
 func (s *DirSuite) TestRenameDir(c *C) {
-	err := s.FS.MkdirAll("foo", 0644)
+	err := s.FS.MkdirAll("foo", 0755)
 	c.Assert(err, IsNil)
 
 	err = util.WriteFile(s.FS, "foo/bar", nil, 0644)
diff --git a/test/fs.go b/test/fs.go
@@ -188,7 +188,7 @@ func (s *FilesystemSuite) TestRemoveAllRelative(c *C) {
 }
 
 func (s *FilesystemSuite) TestReadDir(c *C) {
-	err := s.FS.MkdirAll("qux", 0644)
+	err := s.FS.MkdirAll("qux", 0755)
 	c.Assert(err, IsNil)
 
 	files := []string{"foo", "bar", "qux/baz", "qux/qux"}

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ func (s DirSuite) TestMkdirAllWithExistingFile(c C) {`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`func (s DirSuite) TestStatDir(c C) {`
`89`		`- s.FS.MkdirAll("foo/bar", 0644)`
	`89`	`+ s.FS.MkdirAll("foo/bar", 0755)`
`90`	`90`
`91`	`91`	`fi, err := s.FS.Stat("foo/bar")`
`92`	`92`	`c.Assert(err, IsNil)`
`@@ -164,7 +164,7 @@ func (s DirSuite) TestReadDirNested(c C) {`
`164`	`164`	`}`
`165`	`165`
`166`	`166`	`func (s DirSuite) TestReadDirWithMkDirAll(c C) {`
`167`		`- err := s.FS.MkdirAll("qux", 0644)`
	`167`	`+ err := s.FS.MkdirAll("qux", 0755)`
`168`	`168`	`c.Assert(err, IsNil)`
`169`	`169`
`170`	`170`	`files := []string{"qux/baz", "qux/qux"}`
`@@ -239,7 +239,7 @@ func (s DirSuite) TestRenameToDir(c C) {`
`239`	`239`	`}`
`240`	`240`
`241`	`241`	`func (s DirSuite) TestRenameDir(c C) {`
`242`		`- err := s.FS.MkdirAll("foo", 0644)`
	`242`	`+ err := s.FS.MkdirAll("foo", 0755)`
`243`	`243`	`c.Assert(err, IsNil)`
`244`	`244`
`245`	`245`	`err = util.WriteFile(s.FS, "foo/bar", nil, 0644)`
Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,7 @@ func (s FilesystemSuite) TestRemoveAllRelative(c C) {`
`188`	`188`	`}`
`189`	`189`
`190`	`190`	`func (s FilesystemSuite) TestReadDir(c C) {`
`191`		`- err := s.FS.MkdirAll("qux", 0644)`
	`191`	`+ err := s.FS.MkdirAll("qux", 0755)`
`192`	`192`	`c.Assert(err, IsNil)`
`193`	`193`
`194`	`194`	`files := []string{"foo", "bar", "qux/baz", "qux/qux"}`