Add support for Chmod on billy.Filesystem #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@pjbgf as hinted at in #157, I'd love to see this backported 🙂 Differences to the version on main are the usage of |
pjbgf
requested changes
Dec 4, 2025
Member
pjbgf
left a comment
pjbgf
left a comment
There was a problem hiding this comment.
Thanks for backporting this @bitfehler. Just a nit, otherwise LGTM:
bitfehler
force-pushed
the
releases/v5.x
branch
from
625098d to
a78cbd0
Compare
The billy package contains a `Change` interface type, which seems to have gone unused for several years now, presumably due to the difficulty of implementing most of the required methods for all supported platforms. This commit splits out a `Chmod` interface from it, which is supported on all platforms. The interface is implemented in all applicable abstractions. Supporting `chmod` in billy would help with issues such as go-git/go-git#588 This is a backport of commit 601c531 on main (go-git#157). Signed-off-by: Conrad Hoffmann <[email protected]>
bitfehler
force-pushed
the
releases/v5.x
branch
from
a78cbd0 to
94b84fc
Compare
pjbgf
approved these changes
Dec 4, 2025
Member
pjbgf
left a comment
pjbgf
left a comment
There was a problem hiding this comment.
@bitfehler thanks for working on this. 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The billy package contains a
Changeinterface type, which seems to have gone unused for several years now, presumably due to the difficulty of implementing most of the required methods for all supported platforms.This commit splits out a
Chmodinterface from it, which is supported on all platforms. The interface is implemented in all applicable abstractions.Supporting
chmodin billy would help with issues such as go-git/go-git#588This is a backport of commit 601c531 on main (#157).