File read-able check should ignore file creation flags #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flags like O_CREATE and O_TRUNCATE don't actually impact the access that a process can have to an open file. When checking whether a process has read access, all that really matters is that the file isn't opened with O_WRONLY.
mcuadros
force-pushed
the
master
branch
6 times, most recently
from
609712c to
3d7f61f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently you'll get an error when you try to read from a file which was opened
using a mode like O_RDONLY | O_CREATE, because the check for "is this file
read-able" checks for
((flags | O_RDWR) || flags == 0).With this change, all we check for is that the file was not opened with O_WRONLY.
Flags like O_CREATE and O_TRUNCATE don't actually impact the access
that a process can have to an open file. When checking whether
a process has read access, all that really matters is that the
file isn't opened with O_WRONLY.