Improve memory usage in Commit.IsImageFile (#95)

mrexodia · lafriks · commit 619663493e54 · 2017-11-28T17:24:08.000+02:00
Signed-off-by: Duncan Ogilvie &lt;mr.exodia.tpodt@gmail.com&gt;
diff --git a/commit.go b/commit.go
@@ -98,10 +98,11 @@ func (c *Commit) IsImageFile(name string) bool {
 		return false
 	}
 
-	dataRc, err := blob.Data()
+	dataRc, err := blob.DataAsync()
 	if err != nil {
 		return false
 	}
+	defer dataRc.Close()
 	buf := make([]byte, 1024)
 	n, _ := dataRc.Read(buf)
 	buf = buf[:n]

Original file line number	Diff line number	Diff line change
`@@ -98,10 +98,11 @@ func (c *Commit) IsImageFile(name string) bool {`
`98`	`98`	`return false`
`99`	`99`	`}`
`100`	`100`
`101`		`- dataRc, err := blob.Data()`
	`101`	`+ dataRc, err := blob.DataAsync()`
`102`	`102`	`if err != nil {`
`103`	`103`	`return false`
`104`	`104`	`}`
	`105`	`+ defer dataRc.Close()`
`105`	`106`	`buf := make([]byte, 1024)`
`106`	`107`	`n, _ := dataRc.Read(buf)`
`107`	`108`	`buf = buf[:n]`