Skip to content

Commit 00a56ef

Browse files
committed
Add composor source field
1 parent 7e596bd commit 00a56ef

File tree

3 files changed

+27
-5
lines changed

3 files changed

+27
-5
lines changed

models/packages/descriptor.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,9 +110,12 @@ func GetPackageDescriptor(ctx context.Context, pv *PackageVersion) (*PackageDesc
110110
if err != nil {
111111
return nil, err
112112
}
113-
repository, err := repo_model.GetRepositoryByID(ctx, p.RepoID)
114-
if err != nil && !repo_model.IsErrRepoNotExist(err) {
115-
return nil, err
113+
var repository *repo_model.Repository
114+
if p.RepoID > 0 {
115+
repository, err = repo_model.GetRepositoryByID(ctx, p.RepoID)
116+
if err != nil && !repo_model.IsErrRepoNotExist(err) {
117+
return nil, err
118+
}
116119
}
117120
creator, err := user_model.GetUserByID(ctx, pv.CreatorID)
118121
if err != nil {

routers/api/packages/composer/api.go

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,13 +66,15 @@ type PackageMetadataResponse struct {
6666
}
6767

6868
// PackageVersionMetadata contains package metadata
69+
// https://getcomposer.org/doc/05-repositories.md#package
6970
type PackageVersionMetadata struct {
7071
*composer_module.Metadata
7172
Name string `json:"name"`
7273
Version string `json:"version"`
7374
Type string `json:"type"`
7475
Created time.Time `json:"time"`
7576
Dist Dist `json:"dist"`
77+
Source Source `json:"source"`
7678
}
7779

7880
// Dist contains package download information
@@ -82,6 +84,13 @@ type Dist struct {
8284
Checksum string `json:"shasum"`
8385
}
8486

87+
// Source contains package source information
88+
type Source struct {
89+
URL string `json:"url"`
90+
Type string `json:"type"`
91+
Reference string `json:"reference"`
92+
}
93+
8594
func createPackageMetadataResponse(registryURL string, pds []*packages_model.PackageDescriptor) *PackageMetadataResponse {
8695
versions := make([]*PackageVersionMetadata, 0, len(pds))
8796

@@ -94,7 +103,7 @@ func createPackageMetadataResponse(registryURL string, pds []*packages_model.Pac
94103
}
95104
}
96105

97-
versions = append(versions, &PackageVersionMetadata{
106+
pkg := PackageVersionMetadata{
98107
Name: pd.Package.Name,
99108
Version: pd.Version.Version,
100109
Type: packageType,
@@ -105,7 +114,16 @@ func createPackageMetadataResponse(registryURL string, pds []*packages_model.Pac
105114
URL: fmt.Sprintf("%s/files/%s/%s/%s", registryURL, url.PathEscape(pd.Package.LowerName), url.PathEscape(pd.Version.LowerVersion), url.PathEscape(pd.Files[0].File.LowerName)),
106115
Checksum: pd.Files[0].Blob.HashSHA1,
107116
},
108-
})
117+
}
118+
if pd.Repository != nil {
119+
pkg.Source = Source{
120+
URL: pd.Repository.HTMLURL(),
121+
Type: "git",
122+
Reference: pd.Version.Version,
123+
}
124+
}
125+
126+
versions = append(versions, &pkg)
109127
}
110128

111129
return &PackageMetadataResponse{

tests/integration/api_packages_composer_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,6 +215,7 @@ func TestPackageComposer(t *testing.T) {
215215
assert.Equal(t, packageAuthor, pkgs[0].Authors[0].Name)
216216
assert.Equal(t, "zip", pkgs[0].Dist.Type)
217217
assert.Equal(t, "4f5fa464c3cb808a1df191dbf6cb75363f8b7072", pkgs[0].Dist.Checksum)
218+
// TODO: add a test for repository field after link package to a repository via API is implemented
218219
assert.Len(t, pkgs[0].Bin, 1)
219220
assert.Equal(t, packageBin, pkgs[0].Bin[0])
220221
})

0 commit comments

Comments
 (0)