Skip to content

Commit 02a4515

Browse files
committed
update test to as this API is no longer used in the frontend, it uses API page size
1 parent aef1d49 commit 02a4515

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

tests/integration/api_issue_test.go

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -266,10 +266,10 @@ func TestAPIEditIssue(t *testing.T) {
266266
func TestAPISearchIssues(t *testing.T) {
267267
defer tests.PrepareTestEnv(t)()
268268

269-
// as this API was used in the frontend, it uses UI page size
269+
// as this API is no longer used in the frontend, it uses API page size
270270
expectedIssueCount := 20 // from the fixtures
271-
if expectedIssueCount > setting.UI.IssuePagingNum {
272-
expectedIssueCount = setting.UI.IssuePagingNum
271+
if expectedIssueCount > setting.API.MaxResponseItems {
272+
expectedIssueCount = setting.API.MaxResponseItems
273273
}
274274

275275
link, _ := url.Parse("/api/v1/repos/issues/search")
@@ -314,7 +314,8 @@ func TestAPISearchIssues(t *testing.T) {
314314
resp = MakeRequest(t, req, http.StatusOK)
315315
DecodeJSON(t, resp, &apiIssues)
316316
assert.Equal(t, "22", resp.Header().Get("X-Total-Count"))
317-
assert.Len(t, apiIssues, 20)
317+
// 30 is default page size now
318+
assert.Len(t, apiIssues, 22)
318319

319320
query.Add("limit", "10")
320321
link.RawQuery = query.Encode()
@@ -370,10 +371,10 @@ func TestAPISearchIssues(t *testing.T) {
370371
func TestAPISearchIssuesWithLabels(t *testing.T) {
371372
defer tests.PrepareTestEnv(t)()
372373

373-
// as this API was used in the frontend, it uses UI page size
374+
// as this API is no longer used in the frontend, it uses API page size
374375
expectedIssueCount := 20 // from the fixtures
375-
if expectedIssueCount > setting.UI.IssuePagingNum {
376-
expectedIssueCount = setting.UI.IssuePagingNum
376+
if expectedIssueCount > setting.API.MaxResponseItems {
377+
expectedIssueCount = setting.API.MaxResponseItems
377378
}
378379

379380
link, _ := url.Parse("/api/v1/repos/issues/search")

0 commit comments

Comments
 (0)