Fix lint

lunny · lunny · commit 02d4f0f5bf9f · 2025-09-01T22:36:05.000-07:00
diff --git a/modules/gitrepo/http.go b/modules/gitrepo/http.go
@@ -13,10 +13,15 @@ import (
 )
 
 func serviceCmd(service string) *git.Command {
-	if service == "git-receive-pack" {
+	switch service {
+	case "git-receive-pack":
 		return git.NewCommand("git-receive-pack")
+	case "git-upload-pack":
+		return git.NewCommand("git-upload-pack")
+	default:
+		// the service should be checked before invoking this function
+		panic("unknown service: " + service)
 	}
-	return git.NewCommand("git-upload-pack")
 }
 
 func StatelessRPC(ctx context.Context, storageRepo Repository, service string, extraEnvs []string, input io.Reader, output io.Writer) (string, error) {

Original file line number	Diff line number	Diff line change
`@@ -13,10 +13,15 @@ import (`
`13`	`13`	`)`
`14`	`14`
`15`	`15`	`func serviceCmd(service string) *git.Command {`
`16`		`- if service == "git-receive-pack" {`
	`16`	`+ switch service {`
	`17`	`+ case "git-receive-pack":`
`17`	`18`	`return git.NewCommand("git-receive-pack")`
	`19`	`+ case "git-upload-pack":`
	`20`	`+ return git.NewCommand("git-upload-pack")`
	`21`	`+ default:`
	`22`	`+ // the service should be checked before invoking this function`
	`23`	`+ panic("unknown service: " + service)`
`18`	`24`	`}`
`19`		`- return git.NewCommand("git-upload-pack")`
`20`	`25`	`}`
`21`	`26`
`22`	`27`	`func StatelessRPC(ctx context.Context, storageRepo Repository, service string, extraEnvs []string, input io.Reader, output io.Writer) (string, error) {`