Add comments

Author: bytedream

modules/git/attribute/checker.go

@@ -40,6 +40,8 @@ func checkAttrCommand(gitRepo *git.Repository, treeish string, filenames, attrib
 			cancel = deleteTemporaryFile
 		}
 	} else if cached {
+		// read from existing index instead of working tree, in cases where the repo is bare or the working tree contains
+		// unstaged changes that shouldn't affect the attribute check
 		cmd.AddArguments("--cached")
 	} // else: no treeish, assume it is a not a bare repo, read from working directory
 

services/repository/files/update.go

@@ -492,7 +492,7 @@ func CreateOrUpdateFile(ctx context.Context, t *TemporaryUploadRepository, file
 	var lfsMetaObject *git_model.LFSMetaObject
 	if setting.LFS.StartServer && hasOldBranch {
 		// Check there is no way this can return multiple infos
-		attributesMap, err := attribute.CheckAttributes(ctx, t.gitRepo, "", attribute.CheckAttributeOpts{
+		attributesMap, err := attribute.CheckAttributes(ctx, t.gitRepo, "" /* use temp repo's working dir */, attribute.CheckAttributeOpts{
 			Attributes: []string{attribute.Filter},
 			Filenames:  []string{file.Options.treePath},
 			// An index is set, so it's okay to list the attributes from it

services/repository/files/upload.go

@@ -108,7 +108,7 @@ func UploadRepoFiles(ctx context.Context, repo *repo_model.Repository, doer *use
 
 	var attributesMap map[string]*attribute.Attributes
 	if setting.LFS.StartServer && hasOldBranch {
-		attributesMap, err = attribute.CheckAttributes(ctx, t.gitRepo, "", attribute.CheckAttributeOpts{
+		attributesMap, err = attribute.CheckAttributes(ctx, t.gitRepo, "" /* use temp repo's working dir */, attribute.CheckAttributeOpts{
 			Attributes: []string{attribute.Filter},
 			Filenames:  names,
 			// An index is set, so it's okay to list the attributes from it