some improvements

Author: lunny

modules/repository/temp.go

@@ -36,16 +36,8 @@ func CreateTemporaryPath(prefix string) (string, context.CancelFunc, error) {
 		return "", func() {}, fmt.Errorf("failed to create dir %s-*.git: %w", prefix, err)
 	}
 	return basePath, func() {
-		if err := removeTemporaryPath(basePath); err != nil {
+		if err := util.RemoveAll(basePath); err != nil {
 			log.Error("Unable to remove temporary directory: %s (%v)", basePath, err)
 		}
 	}, nil
 }
-
-// removeTemporaryPath removes the temporary path
-func removeTemporaryPath(basePath string) error {
-	if _, err := os.Stat(basePath); !os.IsNotExist(err) {
-		return util.RemoveAll(basePath)
-	}
-	return nil
-}

services/pull/temp_repo.go

@@ -79,7 +79,7 @@ func createTemporaryRepoForPR(ctx context.Context, pr *issues_model.PullRequest)
 		log.Error("CreateTemporaryPath[%-v]: %v", pr, err)
 		return nil, nil, err
 	}
-	defer cleanup()
+	cancel = cleanup
 
 	prCtx = &prContext{
 		Context:     ctx,