Add advanced labels with priority

* Calculate issue priority when adding/removing labels

Author: lafriks

models/fixtures/label.yml

@@ -4,6 +4,7 @@
   org_id: 0
   name: label1
   color: '#abcdef'
+  priority: high
   exclusive: false
   num_issues: 2
   num_closed_issues: 0

models/issues/issue.go

@@ -232,6 +232,31 @@ func (issue *Issue) LoadLabels(ctx context.Context) (err error) {
 	return nil
 }
 
+// CalculatePriority calculates priority value of an issue based on its labels
+func (issue *Issue) CalculatePriority() {
+	// If no labels are set then set default priority
+	if issue.Labels == nil {
+		issue.Priority = 0
+		return
+	}
+	// Use only the labels that has priority set
+	p := -10000000
+	for _, label := range issue.Labels {
+		if label.Priority.IsEmpty() {
+			continue
+		}
+		if pv := label.Priority.Value(); p < pv {
+			p = pv
+		}
+	}
+	// If no label has priority use default
+	if p == -10000000 {
+		issue.Priority = 0
+	} else {
+		issue.Priority = p
+	}
+}
+
 // LoadPoster loads poster
 func (issue *Issue) LoadPoster(ctx context.Context) (err error) {
 	if issue.Poster == nil && issue.PosterID != 0 {
@@ -521,6 +546,11 @@ func ClearIssueLabels(issue *Issue, doer *user_model.User) (err error) {
 		return err
 	}
 
+	issue.Priority = 0
+	if err = UpdateIssueCols(ctx, issue, "priority"); err != nil {
+		return err
+	}
+
 	if err = committer.Commit(); err != nil {
 		return fmt.Errorf("Commit: %w", err)
 	}
@@ -634,6 +664,11 @@ func ReplaceIssueLabels(issue *Issue, labels []*Label, doer *user_model.User) (e
 		return err
 	}
 
+	issue.CalculatePriority()
+	if err = UpdateIssueCols(ctx, issue, "priority"); err != nil {
+		return err
+	}
+
 	return committer.Commit()
 }
 
@@ -1020,6 +1055,15 @@ func NewIssueWithIndex(ctx context.Context, doer *user_model.User, opts NewIssue
 				return fmt.Errorf("addLabel [id: %d]: %w", label.ID, err)
 			}
 		}
+
+		opts.Issue.Labels = nil
+		if err = opts.Issue.LoadLabels(ctx); err != nil {
+			return err
+		}
+
+		if err = UpdateIssueCols(ctx, opts.Issue, "priority"); err != nil {
+			return err
+		}
 	}
 
 	if err = NewIssueUsers(ctx, opts.Repo, opts.Issue); err != nil {

models/issues/label.go

@@ -86,7 +86,8 @@ type Label struct {
 	Name            string
 	Exclusive       bool
 	Description     string
-	Color           string `xorm:"VARCHAR(7)"`
+	Color           string         `xorm:"VARCHAR(7)"`
+	Priority        label.Priority `xorm:"VARCHAR(20)"`
 	NumIssues       int
 	NumClosedIssues int
 	CreatedUnix     timeutil.TimeStamp `xorm:"INDEX created"`
@@ -204,6 +205,9 @@ func NewLabel(ctx context.Context, l *Label) error {
 	if err != nil {
 		return err
 	}
+	if !l.Priority.IsValid() {
+		return fmt.Errorf("invalid priority: %s", l.Priority)
+	}
 	l.Color = color
 
 	return db.Insert(ctx, l)
@@ -222,6 +226,9 @@ func NewLabels(labels ...*Label) error {
 		if err != nil {
 			return err
 		}
+		if !l.Priority.IsValid() {
+			return fmt.Errorf("invalid priority: %s", l.Priority)
+		}
 		l.Color = color
 
 		if err := db.Insert(ctx, l); err != nil {
@@ -237,9 +244,12 @@ func UpdateLabel(l *Label) error {
 	if err != nil {
 		return err
 	}
+	if !l.Priority.IsValid() {
+		return fmt.Errorf("invalid priority: %s", l.Priority)
+	}
 	l.Color = color
 
-	return updateLabelCols(db.DefaultContext, l, "name", "description", "color", "exclusive")
+	return updateLabelCols(db.DefaultContext, l, "name", "exclusive", "color", "priority", "description")
 }
 
 // DeleteLabel delete a label
@@ -663,6 +673,11 @@ func NewIssueLabel(issue *Issue, label *Label, doer *user_model.User) (err error
 		return err
 	}
 
+	issue.CalculatePriority()
+	if err = UpdateIssueCols(ctx, issue, "priority"); err != nil {
+		return err
+	}
+
 	return committer.Commit()
 }
 
@@ -703,6 +718,11 @@ func NewIssueLabels(issue *Issue, labels []*Label, doer *user_model.User) (err e
 		return err
 	}
 
+	issue.CalculatePriority()
+	if err = UpdateIssueCols(ctx, issue, "priority"); err != nil {
+		return err
+	}
+
 	return committer.Commit()
 }
 
@@ -741,7 +761,12 @@ func DeleteIssueLabel(ctx context.Context, issue *Issue, label *Label, doer *use
 	}
 
 	issue.Labels = nil
-	return issue.LoadLabels(ctx)
+	if err := issue.LoadLabels(ctx); err != nil {
+		return err
+	}
+
+	issue.CalculatePriority()
+	return UpdateIssueCols(ctx, issue, "priority")
 }
 
 // DeleteLabelsByRepoID  deletes labels of some repository