Skip to content

Commit 05d3643

Browse files
committed
make magic string an const
1 parent 6619b1e commit 05d3643

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

models/issues/pull.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ import (
2929

3030
var ErrMustCollaborator = util.NewPermissionDeniedErrorf("user must be a collaborator")
3131

32+
const reviewedBy = "Reviewed-by: "
33+
3234
// ErrPullRequestNotExist represents a "PullRequestNotExist" kind of error.
3335
type ErrPullRequestNotExist struct {
3436
ID int64
@@ -392,7 +394,7 @@ func (pr *PullRequest) getReviewedByLines(ctx context.Context, writer io.Writer)
392394
} else if review.Reviewer == nil {
393395
continue
394396
}
395-
if _, err := writer.Write([]byte("Reviewed-by: ")); err != nil {
397+
if _, err := writer.Write([]byte(reviewedBy)); err != nil {
396398
return err
397399
}
398400
if _, err := writer.Write([]byte(review.Reviewer.NewGitSig().String())); err != nil {

0 commit comments

Comments
 (0)