fine tune comments

Author: wxiaoguang

modules/templates/helper_test.go

@@ -102,50 +102,3 @@ func TestTemplateTruthy(t *testing.T) {
 	}
 	assert.True(t, truthyCount != 0 && truthyCount != len(cases))
 }
-
-func TestQueryBuild(t *testing.T) {
-	t.Run("construct", func(t *testing.T) {
-		assert.Equal(t, "", string(queryBuild()))
-		assert.Equal(t, "a=1&b=true", string(queryBuild("a", 1, "b", "true")))
-		assert.Equal(t, "?k=1", string(queryBuild("?", "k", 1)))
-		assert.Equal(t, "?a=b&k=1", string(queryBuild("?a=b", "k", 1)))
-		assert.Equal(t, "&k=1", string(queryBuild("&", "k", 1)))
-		assert.Equal(t, "&a=b&k=1", string(queryBuild("&a=b", "k", 1)))
-	})
-	t.Run("replace", func(t *testing.T) {
-		assert.Equal(t, "a=1&c=d&e=f", string(queryBuild(QueryString("a=b&c=d&e=f"), "a", 1)))
-		assert.Equal(t, "a=b&c=1&e=f", string(queryBuild(QueryString("a=b&c=d&e=f"), "c", 1)))
-		assert.Equal(t, "a=b&c=d&e=1", string(queryBuild(QueryString("a=b&c=d&e=f"), "e", 1)))
-		assert.Equal(t, "a=b&c=d&e=f&k=1", string(queryBuild(QueryString("a=b&c=d&e=f"), "k", 1)))
-	})
-	t.Run("replace-?", func(t *testing.T) {
-		assert.Equal(t, "?a=1&c=d&e=f", string(queryBuild(QueryString("?a=b&c=d&e=f"), "a", 1)))
-		assert.Equal(t, "?a=b&c=1&e=f", string(queryBuild(QueryString("?a=b&c=d&e=f"), "c", 1)))
-		assert.Equal(t, "?a=b&c=d&e=1", string(queryBuild(QueryString("?a=b&c=d&e=f"), "e", 1)))
-		assert.Equal(t, "?a=b&c=d&e=f&k=1", string(queryBuild(QueryString("?a=b&c=d&e=f"), "k", 1)))
-	})
-	t.Run("replace-&", func(t *testing.T) {
-		assert.Equal(t, "&a=1&c=d&e=f", string(queryBuild(QueryString("&a=b&c=d&e=f"), "a", 1)))
-		assert.Equal(t, "&a=b&c=1&e=f", string(queryBuild(QueryString("&a=b&c=d&e=f"), "c", 1)))
-		assert.Equal(t, "&a=b&c=d&e=1", string(queryBuild(QueryString("&a=b&c=d&e=f"), "e", 1)))
-		assert.Equal(t, "&a=b&c=d&e=f&k=1", string(queryBuild(QueryString("&a=b&c=d&e=f"), "k", 1)))
-	})
-	t.Run("delete", func(t *testing.T) {
-		assert.Equal(t, "c=d&e=f", string(queryBuild(QueryString("a=b&c=d&e=f"), "a", "")))
-		assert.Equal(t, "a=b&e=f", string(queryBuild(QueryString("a=b&c=d&e=f"), "c", "")))
-		assert.Equal(t, "a=b&c=d", string(queryBuild(QueryString("a=b&c=d&e=f"), "e", "")))
-		assert.Equal(t, "a=b&c=d&e=f", string(queryBuild(QueryString("a=b&c=d&e=f"), "k", "")))
-	})
-	t.Run("delete-?", func(t *testing.T) {
-		assert.Equal(t, "?c=d&e=f", string(queryBuild(QueryString("?a=b&c=d&e=f"), "a", "")))
-		assert.Equal(t, "?a=b&e=f", string(queryBuild(QueryString("?a=b&c=d&e=f"), "c", "")))
-		assert.Equal(t, "?a=b&c=d", string(queryBuild(QueryString("?a=b&c=d&e=f"), "e", "")))
-		assert.Equal(t, "?a=b&c=d&e=f", string(queryBuild(QueryString("?a=b&c=d&e=f"), "k", "")))
-	})
-	t.Run("delete-&", func(t *testing.T) {
-		assert.Equal(t, "&c=d&e=f", string(queryBuild(QueryString("&a=b&c=d&e=f"), "a", "")))
-		assert.Equal(t, "&a=b&e=f", string(queryBuild(QueryString("&a=b&c=d&e=f"), "c", "")))
-		assert.Equal(t, "&a=b&c=d", string(queryBuild(QueryString("&a=b&c=d&e=f"), "e", "")))
-		assert.Equal(t, "&a=b&c=d&e=f", string(queryBuild(QueryString("&a=b&c=d&e=f"), "k", "")))
-	})
-}

routers/web/shared/user/helper.go

@@ -27,6 +27,10 @@ func MakeSelfOnTop(doer *user.User, users []*user.User) []*user.User {
 	return users
 }
 
+// GetFilterUserIDByName tries to get the user ID from the given username.
+// Before, the "issue filter" passes user ID to query the list, but in many cases, it's impossible to pre-fetch the full user list.
+// So it's better to make it work like GitHub: users could input username directly.
+// Old usage: poster=123, new usage: poster=the-user-name (at the moment, non-existing username is treated as poster=0)
 func GetFilterUserIDByName(ctx context.Context, name string) int64 {
 	if name == "" {
 		return 0