cleanup

Author: ChristopherHX

services/actions/notifier_helper.go

@@ -27,7 +27,6 @@ import (
 	api "code.gitea.io/gitea/modules/structs"
 	webhook_module "code.gitea.io/gitea/modules/webhook"
 	"code.gitea.io/gitea/services/convert"
-	notify_service "code.gitea.io/gitea/services/notify"
 
 	"github.com/nektos/act/pkg/model"
 )
@@ -349,26 +348,6 @@ func handleWorkflows(
 			log.Error("PrepareRun: %v", err)
 			continue
 		}
-
-		alljobs, err := db.Find[actions_model.ActionRunJob](ctx, actions_model.FindRunJobOptions{RunID: run.ID})
-		if err != nil {
-			log.Error("FindRunJobs: %v", err)
-			continue
-		}
-		// FIXME PERF skip this for schedule, dispatch etc.
-		CreateCommitStatus(ctx, alljobs...)
-		if len(alljobs) > 0 {
-			job := alljobs[0]
-			err := job.LoadRun(ctx)
-			if err != nil {
-				log.Error("LoadRun: %v", err)
-				continue
-			}
-			notify_service.WorkflowRunStatusUpdate(ctx, job.Run.Repo, job.Run.TriggerUser, job.Run)
-		}
-		for _, job := range alljobs {
-			notify_service.WorkflowJobStatusUpdate(ctx, input.Repo, input.Doer, job, nil)
-		}
 	}
 	return nil
 }

services/actions/run.go

@@ -57,10 +57,15 @@ func PrepareRun(ctx context.Context, content []byte, run *actions_model.ActionRu
 		return fmt.Errorf("InsertRun: %w", err)
 	}
 
+	// FIXME PERF do we need this db round trip?
 	allJobs, err := db.Find[actions_model.ActionRunJob](ctx, actions_model.FindRunJobOptions{RunID: run.ID})
 	if err != nil {
 		log.Error("FindRunJobs: %v", err)
 	}
+
+	// FIXME PERF skip this for schedule, dispatch etc.
+	CreateCommitStatus(ctx, allJobs...)
+
 	err = run.LoadAttributes(ctx)
 	if err != nil {
 		log.Error("LoadAttributes: %v", err)