ensure we return early if there was an error loading group units

GamerGirlandCo · GamerGirlandCo · commit 0bac8224ea2d · 2025-08-16T17:05:33.000-04:00
diff --git a/models/group/group_team.go b/models/group/group_team.go
@@ -34,6 +34,7 @@ func (g *RepoGroupTeam) UnitAccessModeEx(ctx context.Context, tp unit.Type) (acc
 	accessMode = perm.AccessModeNone
 	if err := g.LoadGroupUnits(ctx); err != nil {
 		log.Warn("Error loading units of team for group[%d] (ID: %d): %s", g.GroupID, g.TeamID, err.Error())
+		return accessMode, false
 	}
 	for _, u := range g.Units {
 		if u.Type == tp {

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,7 @@ func (g *RepoGroupTeam) UnitAccessModeEx(ctx context.Context, tp unit.Type) (acc`
`34`	`34`	`accessMode = perm.AccessModeNone`
`35`	`35`	`if err := g.LoadGroupUnits(ctx); err != nil {`
`36`	`36`	`log.Warn("Error loading units of team for group[%d] (ID: %d): %s", g.GroupID, g.TeamID, err.Error())`
	`37`	`+ return accessMode, false`
`37`	`38`	`}`
`38`	`39`	`for _, u := range g.Units {`
`39`	`40`	`if u.Type == tp {`