Skip to content

Commit 0e501fe

Browse files
committed
fix linting issues and failing test
1 parent ac9d6af commit 0e501fe

File tree

4 files changed

+3
-8
lines changed

4 files changed

+3
-8
lines changed

assets/go-licenses.json

Lines changed: 0 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ require (
9898
github.com/pkg/errors v0.9.1
9999
github.com/pquerna/otp v1.4.0
100100
github.com/prometheus/client_golang v1.22.0
101-
github.com/prometheus/common v0.63.0
102101
github.com/quasoft/websspi v1.1.2
103102
github.com/redis/go-redis/v9 v9.7.3
104103
github.com/robfig/cron/v3 v3.0.1
@@ -244,6 +243,7 @@ require (
244243
github.com/pjbgf/sha1cd v0.3.2 // indirect
245244
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
246245
github.com/prometheus/client_model v0.6.2 // indirect
246+
github.com/prometheus/common v0.63.0 // indirect
247247
github.com/prometheus/procfs v0.16.1 // indirect
248248
github.com/rhysd/actionlint v1.7.7 // indirect
249249
github.com/rivo/uniseg v0.4.7 // indirect

modules/git/command.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import (
3232
// In most cases, it shouldn't be used. Use AddXxx function instead
3333
type TrustedCmdArgs []internal.CmdArg
3434

35-
const gitOperation = "command"
35+
// const gitOperation = "command"
3636

3737
var (
3838
// globalCommandArgs global command args for external package setting

routers/common/middleware_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ func TestMetricsMiddlewere(t *testing.T) {
2323
testServer := httptest.NewServer(r)
2424
// Check all defined metrics
2525
verify := func(i int) {
26-
assert.Equal(t, testutil.CollectAndCount(reqDurationHistogram, "http_server_request_duration"), i)
26+
assert.Equal(t, testutil.CollectAndCount(reqDurationHistogram, "http_server_request_duration_seconds"), i)
2727
assert.Equal(t, testutil.CollectAndCount(reqSizeHistogram, "http_server_request_body_size"), i)
2828
assert.Equal(t, testutil.CollectAndCount(respSizeHistogram, "http_server_response_body_size"), i)
2929
assert.Equal(t, testutil.CollectAndCount(reqInflightGauge, "http_server_active_requests"), i)

0 commit comments

Comments
 (0)