|
| 1 | +// Copyright 2026 The Gitea Authors. All rights reserved. |
| 2 | +// SPDX-License-Identifier: MIT |
| 3 | + |
| 4 | +package actions |
| 5 | + |
| 6 | +import ( |
| 7 | + "testing" |
| 8 | + |
| 9 | + "code.gitea.io/gitea/models/db" |
| 10 | + "code.gitea.io/gitea/models/unittest" |
| 11 | + |
| 12 | + "github.com/stretchr/testify/assert" |
| 13 | +) |
| 14 | + |
| 15 | +func TestActionRunJob_MaxParallel(t *testing.T) { |
| 16 | + assert.NoError(t, unittest.PrepareTestDatabase()) |
| 17 | + ctx := db.DefaultContext |
| 18 | + |
| 19 | + t.Run("NoMaxParallel", func(t *testing.T) { |
| 20 | + job := &ActionRunJob{ |
| 21 | + RunID: 1, |
| 22 | + RepoID: 1, |
| 23 | + OwnerID: 1, |
| 24 | + JobID: "test-job-1", |
| 25 | + Name: "Test Job", |
| 26 | + Status: StatusWaiting, |
| 27 | + MaxParallel: 0, // No limit |
| 28 | + } |
| 29 | + assert.NoError(t, db.Insert(ctx, job)) |
| 30 | + |
| 31 | + retrieved, err := GetRunJobByID(ctx, job.ID) |
| 32 | + assert.NoError(t, err) |
| 33 | + assert.Equal(t, 0, retrieved.MaxParallel) |
| 34 | + }) |
| 35 | + |
| 36 | + t.Run("WithMaxParallel", func(t *testing.T) { |
| 37 | + job := &ActionRunJob{ |
| 38 | + RunID: 1, |
| 39 | + RepoID: 1, |
| 40 | + OwnerID: 1, |
| 41 | + JobID: "test-job-2", |
| 42 | + Name: "Matrix Job", |
| 43 | + Status: StatusWaiting, |
| 44 | + MaxParallel: 3, |
| 45 | + } |
| 46 | + assert.NoError(t, db.Insert(ctx, job)) |
| 47 | + |
| 48 | + retrieved, err := GetRunJobByID(ctx, job.ID) |
| 49 | + assert.NoError(t, err) |
| 50 | + assert.Equal(t, 3, retrieved.MaxParallel) |
| 51 | + }) |
| 52 | + |
| 53 | + t.Run("MatrixID", func(t *testing.T) { |
| 54 | + job := &ActionRunJob{ |
| 55 | + RunID: 1, |
| 56 | + RepoID: 1, |
| 57 | + OwnerID: 1, |
| 58 | + JobID: "test-job-3", |
| 59 | + Name: "Matrix Job with ID", |
| 60 | + Status: StatusWaiting, |
| 61 | + MaxParallel: 2, |
| 62 | + MatrixID: "os:ubuntu,node:16", |
| 63 | + } |
| 64 | + assert.NoError(t, db.Insert(ctx, job)) |
| 65 | + |
| 66 | + retrieved, err := GetRunJobByID(ctx, job.ID) |
| 67 | + assert.NoError(t, err) |
| 68 | + assert.Equal(t, 2, retrieved.MaxParallel) |
| 69 | + assert.Equal(t, "os:ubuntu,node:16", retrieved.MatrixID) |
| 70 | + }) |
| 71 | + |
| 72 | + t.Run("UpdateMaxParallel", func(t *testing.T) { |
| 73 | + job := &ActionRunJob{ |
| 74 | + RunID: 1, |
| 75 | + RepoID: 1, |
| 76 | + OwnerID: 1, |
| 77 | + JobID: "test-job-4", |
| 78 | + Name: "Updatable Job", |
| 79 | + Status: StatusWaiting, |
| 80 | + MaxParallel: 5, |
| 81 | + } |
| 82 | + assert.NoError(t, db.Insert(ctx, job)) |
| 83 | + |
| 84 | + // Update max parallel |
| 85 | + job.MaxParallel = 10 |
| 86 | + _, err := UpdateRunJob(ctx, job, nil, "max_parallel") |
| 87 | + assert.NoError(t, err) |
| 88 | + |
| 89 | + retrieved, err := GetRunJobByID(ctx, job.ID) |
| 90 | + assert.NoError(t, err) |
| 91 | + assert.Equal(t, 10, retrieved.MaxParallel) |
| 92 | + }) |
| 93 | +} |
| 94 | + |
| 95 | +func TestActionRunJob_MaxParallelEnforcement(t *testing.T) { |
| 96 | + assert.NoError(t, unittest.PrepareTestDatabase()) |
| 97 | + ctx := db.DefaultContext |
| 98 | + |
| 99 | + t.Run("EnforceMaxParallel", func(t *testing.T) { |
| 100 | + runID := int64(5000) |
| 101 | + jobID := "parallel-enforced-job" |
| 102 | + maxParallel := 2 |
| 103 | + |
| 104 | + // Create jobs simulating matrix execution |
| 105 | + jobs := []*ActionRunJob{ |
| 106 | + {RunID: runID, RepoID: 1, OwnerID: 1, JobID: jobID, Name: "Job 1", Status: StatusRunning, MaxParallel: maxParallel, MatrixID: "version:1"}, |
| 107 | + {RunID: runID, RepoID: 1, OwnerID: 1, JobID: jobID, Name: "Job 2", Status: StatusRunning, MaxParallel: maxParallel, MatrixID: "version:2"}, |
| 108 | + {RunID: runID, RepoID: 1, OwnerID: 1, JobID: jobID, Name: "Job 3", Status: StatusWaiting, MaxParallel: maxParallel, MatrixID: "version:3"}, |
| 109 | + {RunID: runID, RepoID: 1, OwnerID: 1, JobID: jobID, Name: "Job 4", Status: StatusWaiting, MaxParallel: maxParallel, MatrixID: "version:4"}, |
| 110 | + } |
| 111 | + |
| 112 | + for _, job := range jobs { |
| 113 | + assert.NoError(t, db.Insert(ctx, job)) |
| 114 | + } |
| 115 | + |
| 116 | + // Verify running count |
| 117 | + runningCount, err := CountRunningJobsByWorkflowAndRun(ctx, runID, jobID) |
| 118 | + assert.NoError(t, err) |
| 119 | + assert.Equal(t, maxParallel, runningCount, "Should have exactly max-parallel jobs running") |
| 120 | + |
| 121 | + // Simulate job completion |
| 122 | + jobs[0].Status = StatusSuccess |
| 123 | + _, err = UpdateRunJob(ctx, jobs[0], nil, "status") |
| 124 | + assert.NoError(t, err) |
| 125 | + |
| 126 | + // Now running count should be 1 |
| 127 | + runningCount, err = CountRunningJobsByWorkflowAndRun(ctx, runID, jobID) |
| 128 | + assert.NoError(t, err) |
| 129 | + assert.Equal(t, 1, runningCount) |
| 130 | + |
| 131 | + // Simulate next job starting |
| 132 | + jobs[2].Status = StatusRunning |
| 133 | + _, err = UpdateRunJob(ctx, jobs[2], nil, "status") |
| 134 | + assert.NoError(t, err) |
| 135 | + |
| 136 | + // Back to max-parallel |
| 137 | + runningCount, err = CountRunningJobsByWorkflowAndRun(ctx, runID, jobID) |
| 138 | + assert.NoError(t, err) |
| 139 | + assert.Equal(t, maxParallel, runningCount) |
| 140 | + }) |
| 141 | +} |
0 commit comments