Update services/auth/source/ldap/source_sync.go

raucao · wxiaoguang · web-flow · commit 1366ca3bf91e · 2025-06-01T14:49:25.000+02:00
Co-authored-by: wxiaoguang &lt;wxiaoguang@gmail.com&gt;
diff --git a/services/auth/source/ldap/source_sync.go b/services/auth/source/ldap/source_sync.go
@@ -178,7 +178,7 @@ func (source *Source) Sync(ctx context.Context, updateExisting bool) error {
 				}
 			}
 
-			if err == nil && source.AttributeAvatar != "" {
+			if source.AttributeAvatar != "" {
 				if len(su.Avatar) > 0 && usr.IsUploadAvatarChanged(su.Avatar) {
 					log.Trace("SyncExternalUsers[%s]: Uploading new avatar for %s", source.AuthSource.Name, usr.Name)
 					_ = user_service.UploadAvatar(ctx, usr, su.Avatar)

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ func (source *Source) Sync(ctx context.Context, updateExisting bool) error {`
`178`	`178`	`}`
`179`	`179`	`}`
`180`	`180`
`181`		`- if err == nil && source.AttributeAvatar != "" {`
	`181`	`+ if source.AttributeAvatar != "" {`
`182`	`182`	`if len(su.Avatar) > 0 && usr.IsUploadAvatarChanged(su.Avatar) {`
`183`	`183`	`log.Trace("SyncExternalUsers[%s]: Uploading new avatar for %s", source.AuthSource.Name, usr.Name)`
`184`	`184`	`_ = user_service.UploadAvatar(ctx, usr, su.Avatar)`