A small optimization to load empty reviews

lunny · lunny · commit 13ee43a6ba31 · 2025-02-13T12:15:17.000-08:00
diff --git a/models/issues/comment_code.go b/models/issues/comment_code.go
@@ -86,8 +86,10 @@ func findCodeComments(ctx context.Context, opts FindCommentsOptions, issue *Issu
 			ids = append(ids, comment.ReviewID)
 		}
 	}
-	if err := e.In("id", ids).Find(&reviews); err != nil {
-		return nil, err
+	if len(ids) > 0 {
+		if err := e.In("id", ids).Find(&reviews); err != nil {
+			return nil, err
+		}
 	}
 
 	n := 0

Original file line number	Diff line number	Diff line change
`@@ -86,8 +86,10 @@ func findCodeComments(ctx context.Context, opts FindCommentsOptions, issue *Issu`
`86`	`86`	`ids = append(ids, comment.ReviewID)`
`87`	`87`	`}`
`88`	`88`	`}`
`89`		`- if err := e.In("id", ids).Find(&reviews); err != nil {`
`90`		`- return nil, err`
	`89`	`+ if len(ids) > 0 {`
	`90`	`+ if err := e.In("id", ids).Find(&reviews); err != nil {`
	`91`	`+ return nil, err`
	`92`	`+ }`
`91`	`93`	`}`
`92`	`94`
`93`	`95`	`n := 0`