refactor(tests): use b.Loop()

Author: TheFox0x7

models/auth/oauth2_test.go

@@ -25,7 +25,7 @@ func TestOAuth2Application_GenerateClientSecret(t *testing.T) {
 func BenchmarkOAuth2Application_GenerateClientSecret(b *testing.B) {
 	assert.NoError(b, unittest.PrepareTestDatabase())
 	app := unittest.AssertExistsAndLoadBean(b, &auth_model.OAuth2Application{ID: 1})
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		_, _ = app.GenerateClientSecret(db.DefaultContext)
 	}
 }

models/unittest/fixtures_test.go

@@ -99,15 +99,15 @@ func BenchmarkFixturesLoader(b *testing.B) {
 	// BenchmarkFixturesLoader/Internal
 	// BenchmarkFixturesLoader/Internal-12       	    1746	    670457 ns/op
 	b.Run("Internal", func(b *testing.B) {
-		for i := 0; i < b.N; i++ {
+		for b.Loop() {
 			require.NoError(b, loaderInternal.Load())
 		}
 	})
 	b.Run("Vendor", func(b *testing.B) {
 		if loaderVendor == nil {
 			b.Skip()
 		}
-		for i := 0; i < b.N; i++ {
+		for b.Loop() {
 			require.NoError(b, loaderVendor.Load())
 		}
 	})

models/user/user_test.go

@@ -200,7 +200,7 @@ func BenchmarkHashPassword(b *testing.B) {
 	pass := "password1337"
 	u := &user_model.User{Passwd: pass}
 	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		u.SetPassword(pass)
 	}
 }

modules/git/blob_test.go

@@ -47,7 +47,7 @@ func Benchmark_Blob_Data(b *testing.B) {
 		b.Fatal(err)
 	}
 
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		r, err := testBlob.DataAsync()
 		if err != nil {
 			b.Fatal(err)

modules/git/commit_info_test.go

@@ -158,7 +158,7 @@ func BenchmarkEntries_GetCommitsInfo(b *testing.B) {
 		entries.Sort()
 		b.ResetTimer()
 		b.Run(benchmark.name, func(b *testing.B) {
-			for i := 0; i < b.N; i++ {
+			for b.Loop() {
 				_, _, err := entries.GetCommitsInfo(b.Context(), commit, "")
 				if err != nil {
 					b.Fatal(err)

modules/git/repo_branch_test.go

@@ -47,7 +47,7 @@ func BenchmarkRepository_GetBranches(b *testing.B) {
 	}
 	defer bareRepo1.Close()
 
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		_, _, err := bareRepo1.GetBranchNames(0, 0)
 		if err != nil {
 			b.Fatal(err)

modules/markup/html_test.go

@@ -522,7 +522,7 @@ func BenchmarkEmojiPostprocess(b *testing.B) {
 		data += data
 	}
 	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		var res strings.Builder
 		err := markup.PostProcessDefault(markup.NewTestRenderContext(localMetas), strings.NewReader(data), &res)
 		assert.NoError(b, err)

modules/markup/markdown/markdown_benchmark_test.go

@@ -12,14 +12,14 @@ import (
 
 func BenchmarkSpecializedMarkdown(b *testing.B) {
 	// 240856	      4719 ns/op
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		markdown.SpecializedMarkdown(&markup.RenderContext{})
 	}
 }
 
 func BenchmarkMarkdownRender(b *testing.B) {
 	// 23202	     50840 ns/op
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		_, _ = markdown.RenderString(markup.NewTestRenderContext(), "https://example.com\n- a\n- b\n")
 	}
 }

modules/util/runtime_test.go

@@ -18,14 +18,14 @@ func TestCallerFuncName(t *testing.T) {
 func BenchmarkCallerFuncName(b *testing.B) {
 	// BenchmarkCaller/sprintf-12         	12744829	        95.49 ns/op
 	b.Run("sprintf", func(b *testing.B) {
-		for i := 0; i < b.N; i++ {
+		for b.Loop() {
 			_ = fmt.Sprintf("aaaaaaaaaaaaaaaa %s %s %s", "bbbbbbbbbbbbbbbbbbb", b.Name(), "ccccccccccccccccccccc")
 		}
 	})
 	// BenchmarkCaller/caller-12          	10625133	       113.6 ns/op
 	// It is almost as fast as fmt.Sprintf
 	b.Run("caller", func(b *testing.B) {
-		for i := 0; i < b.N; i++ {
+		for b.Loop() {
 			CallerFuncName(1)
 		}
 	})

modules/util/util_test.go

@@ -215,7 +215,7 @@ func TestToUpperASCII(t *testing.T) {
 func BenchmarkToUpper(b *testing.B) {
 	for _, tc := range upperTests {
 		b.Run(tc.in, func(b *testing.B) {
-			for i := 0; i < b.N; i++ {
+			for b.Loop() {
 				ToUpperASCII(tc.in)
 			}
 		})