Address comments from wxiaoguang

Author: brechtvl

routers/web/repo/fork_to_edit.go

@@ -8,7 +8,6 @@ import (
 	"fmt"
 	"net/http"
 	"path"
-	"strings"
 
 	git_model "code.gitea.io/gitea/models/git"
 	access_model "code.gitea.io/gitea/models/perm/access"
@@ -167,27 +166,20 @@ func updateEditRepositoryIsEmpty(ctx *context.Context, editRepo *repo_model.Repo
 		return
 	}
 
-	editGitRepo, err := gitrepo.OpenRepository(git.DefaultContext, editRepo)
+	editGitRepo, err := gitrepo.OpenRepository(ctx, editRepo)
 	if err != nil {
 		log.Error("gitrepo.OpenRepository: %v", err)
 		return
 	}
-	if editGitRepo == nil {
-		return
-	}
+	defer editGitRepo.Close()
 
 	if isEmpty, err := editGitRepo.IsEmpty(); err == nil && !isEmpty {
 		_ = repo_model.UpdateRepositoryCols(ctx, &repo_model.Repository{ID: editRepo.ID, IsEmpty: false}, "is_empty")
 	}
-	editGitRepo.Close()
 }
 
 func forkToEditFileCommon(ctx *context.Context, editOperation, treePath string, notEditableMessage any) {
-	// Check if the filename (and additional path) is specified in the querystring
-	// (filename is a misnomer, but kept for compatibility with GitHub)
-	filePath, _ := path.Split(ctx.Req.URL.Query().Get("filename"))
-	filePath = strings.Trim(filePath, "/")
-	treeNames, treePaths := getParentTreeFields(path.Join(ctx.Repo.TreePath, filePath))
+	treeNames, treePaths := getParentTreeFields(treePath)
 
 	ctx.Data["EditOperation"] = editOperation
 	ctx.Data["TreePath"] = treePath
@@ -202,8 +194,6 @@ func ForkToEditFilePost(ctx *context.Context) {
 
 	editRepo, notEditableMessage := getEditRepository(ctx)
 
-	ctx.Data["PageHasPosted"] = true
-
 	// Fork repository, if it doesn't already exist
 	if editRepo == nil && notEditableMessage == nil {
 		forkRepo := forkRepositoryOrError(ctx, ctx.Doer, repo_service.ForkRepoOptions{

templates/repo/editor/fork.tmpl

@@ -5,7 +5,6 @@
 		{{template "base/alert" .}}
 		<form class="ui edit form" method="post" action="{{.RepoLink}}/_fork_to_edit/{{.BranchName | PathEscapeSegments}}">
 			{{.CsrfTokenHtml}}
-			<input type="hidden" name="page_has_posted" value="{{.PageHasPosted}}">
 			<div class="repo-editor-header">
 				<div class="ui breadcrumb field{{if .Err_TreePath}} error{{end}}">
 					<a class="section" href="{{$.BranchLink}}">{{.Repository.Name}}</a>

templates/repo/view_content.tmpl

@@ -41,9 +41,8 @@
 		<a href="{{.Repository.Link}}/find/{{.RefTypeNameSubURL}}" class="ui compact basic button">{{ctx.Locale.Tr "repo.find_file.go_to_file"}}</a>
 	{{end}}
 
-	{{if and .RefFullName.IsBranch (not .IsViewFile) .Repository.CanEnableEditor}}
-		<button class="ui dropdown basic compact jump button"
-			{{if not .IsSigned}} disabled data-tooltip-content="{{ctx.Locale.Tr "repo.editor.must_be_signed_in"}}"{{end}}>
+	{{if and .RefFullName.IsBranch (not .IsViewFile) .Repository.CanEnableEditor .IsSigned}}
+		<button class="ui dropdown basic compact jump button">
 			{{ctx.Locale.Tr "repo.editor.add_file"}}
 			{{svg "octicon-triangle-down" 14 "dropdown icon"}}
 			<div class="menu">