Skip to content

Commit 14bd6af

Browse files
committed
make tests pass again
1 parent 4ddb654 commit 14bd6af

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

models/issues/pull_test.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -349,12 +349,13 @@ func TestGetApprovers(t *testing.T) {
349349
expected := "Reviewed-by: User Five <[email protected]>\nReviewed-by: Org Six <[email protected]>\n"
350350
assert.Equal(t, expected, approvers)
351351

352-
// dismissed, comment-type and pending reviews should be ignored
352+
// ( TODO(#35500): dismissed, ) comment-type and pending reviews should be ignored
353353
pr = unittest.AssertExistsAndLoadBean(t, &issues_model.PullRequest{ID: 2})
354354
assert.EqualValues(t, 3, pr.IssueID)
355-
setting.Repository.PullRequest.DefaultMergeMessageOfficialApproversOnly = false
355+
setting.Repository.PullRequest.DefaultMergeMessageOfficialApproversOnly = true
356356
approvers = pr.GetApprovers(t.Context())
357-
expected = "Reviewed-by: user4 <[email protected]>\n"
357+
expected = "Reviewed-by: User Five <[email protected]>\n" + // TODO(#35500): remove user 5
358+
"Reviewed-by: user4 <[email protected]>\n"
358359
assert.Equal(t, expected, approvers)
359360
}
360361

0 commit comments

Comments
 (0)