Remove unnecessary data from comment

Author: RedCocoon

models/conversations/comment.go

@@ -135,8 +135,6 @@ type Comment struct {
 	ConversationID int64 `xorm:"INDEX"`
 	Conversation   *Conversation
 
-	DependentConversationID int64 `xorm:"INDEX"`
-
 	CreatedUnix timeutil.TimeStamp `xorm:"INDEX created"`
 	UpdatedUnix timeutil.TimeStamp `xorm:"INDEX updated"`
 
@@ -166,39 +164,6 @@ func (c *Comment) LoadPoster(ctx context.Context) (err error) {
 	return err
 }
 
-// Creates conversation dependency comment
-func createConversationDependencyComment(ctx context.Context, doer *user_model.User, conversation, dependentConversation *Conversation, add bool) (err error) {
-	cType := CommentTypeAddDependency
-	if !add {
-		cType = CommentTypeRemoveDependency
-	}
-	if err = conversation.LoadRepo(ctx); err != nil {
-		return err
-	}
-
-	// Make two comments, one in each conversation
-	opts := &CreateCommentOptions{
-		Type:                    cType,
-		Doer:                    doer,
-		Repo:                    conversation.Repo,
-		Conversation:            conversation,
-		DependentConversationID: dependentConversation.ID,
-	}
-	if _, err = CreateComment(ctx, opts); err != nil {
-		return err
-	}
-
-	opts = &CreateCommentOptions{
-		Type:                    cType,
-		Doer:                    doer,
-		Repo:                    conversation.Repo,
-		Conversation:            dependentConversation,
-		DependentConversationID: conversation.ID,
-	}
-	_, err = CreateComment(ctx, opts)
-	return err
-}
-
 // LoadReactions loads comment reactions
 func (c *Comment) LoadReactions(ctx context.Context, repo *repo_model.Repository) (err error) {
 	if c.Reactions != nil {

services/conversation/conversation.go

@@ -81,7 +81,6 @@ func deleteConversation(ctx context.Context, conversation *conversations_model.C
 		&conversations_model.CommentReaction{ConversationID: conversation.ID},
 		&repo_model.Attachment{ConversationID: conversation.ID},
 		&conversations_model.Comment{ConversationID: conversation.ID},
-		&conversations_model.Comment{DependentConversationID: conversation.ID},
 	); err != nil {
 		return err
 	}