Update services/packages/arch/repository.go

wxiaoguang · web-flow · commit 219d8722ec69 · 2025-02-11T18:41:22.000+08:00
diff --git a/services/packages/arch/repository.go b/services/packages/arch/repository.go
@@ -245,6 +245,9 @@ func buildPackagesIndex(ctx context.Context, ownerID int64, repoVersion *package
 			return err
 		}
 
+		// here we compare the versions but not using SearchLatestVersions because we shouldn't allow "downgrading" to a older version by "latest" one.
+		// https://wiki.archlinux.org/title/Downgrading_packages : randomly downgrading can mess up dependencies:
+		// If a downgrade involves a soname change, all dependencies may need downgrading or rebuilding too.
 		if old, ok := vpfs[current.Version.PackageID]; ok {
 			if compareVersions(old.Version.Version, current.Version.Version) == -1 {
 				vpfs[current.Version.PackageID] = current

Original file line number	Diff line number	Diff line change
`@@ -245,6 +245,9 @@ func buildPackagesIndex(ctx context.Context, ownerID int64, repoVersion *package`
`245`	`245`	`return err`
`246`	`246`	`}`
`247`	`247`
	`248`	`+ // here we compare the versions but not using SearchLatestVersions because we shouldn't allow "downgrading" to a older version by "latest" one.`
	`249`	`+ // https://wiki.archlinux.org/title/Downgrading_packages : randomly downgrading can mess up dependencies:`
	`250`	`+ // If a downgrade involves a soname change, all dependencies may need downgrading or rebuilding too.`
`248`	`251`	`if old, ok := vpfs[current.Version.PackageID]; ok {`
`249`	`252`	`if compareVersions(old.Version.Version, current.Version.Version) == -1 {`
`250`	`253`	`vpfs[current.Version.PackageID] = current`