Skip to content

Commit 2464749

Browse files
committed
fix
1 parent 3ced3a3 commit 2464749

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

templates/projects/view.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
</div>
2020
{{if $canWriteProject}}
2121
<div class="ui compact mini menu">
22-
<a class="item screen-full" data-fullscreen-elements-selector=".projects-view">
22+
<a class="item screen-full">
2323
{{svg "octicon-screen-full"}}
2424
{{ctx.Locale.Tr "projects.enter_fullscreen"}}
2525
</a>

web_src/js/features/repo-projects.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -145,12 +145,10 @@ function initRepoProjectToggleFullScreen(): void {
145145
const exitFullscreenBtn = document.querySelector('.screen-normal');
146146
if (!enterFullscreenBtn || !exitFullscreenBtn) return;
147147

148-
const fullscreenElementsSelector = enterFullscreenBtn.getAttribute('data-fullscreen-elements-selector');
149-
150148
const toggleFullscreenState = (isFullScreen: boolean) => {
151-
toggleFullScreen(fullscreenElementsSelector, isFullScreen);
152-
toggleElem(enterFullscreenBtn);
153-
toggleElem(exitFullscreenBtn);
149+
toggleFullScreen('.projects-view', isFullScreen);
150+
toggleElem(enterFullscreenBtn, !isFullScreen);
151+
toggleElem(exitFullscreenBtn, isFullScreen);
154152
};
155153

156154
enterFullscreenBtn.addEventListener('click', () => toggleFullscreenState(true));

web_src/js/utils.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -192,12 +192,12 @@ export function toggleFullScreen(fullscreenElementsSelector: string, isFullScree
192192

193193
const sourceParentEl = sourceParentSelector ? document.querySelector(sourceParentSelector) : contentEl;
194194

195-
const fullScreenEls = document.querySelectorAll(fullscreenElementsSelector);
195+
const fullScreenEl = document.querySelector(fullscreenElementsSelector);
196196
const outerEl = document.querySelector('.full.height');
197197
toggleClass(fullscreenElementsSelector, 'fullscreen', isFullScreen);
198198
if (isFullScreen) {
199-
for (const e of fullScreenEls) outerEl.append(e);
199+
outerEl.append(fullScreenEl);
200200
} else {
201-
for (const e of fullScreenEls) sourceParentEl.append(e);
201+
sourceParentEl.append(fullScreenEl);
202202
}
203203
}

0 commit comments

Comments
 (0)