Skip to content

Commit 25afea4

Browse files
committed
add comments
1 parent 2c71d33 commit 25afea4

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

web_src/js/modules/fomantic/dropdown.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,15 @@ function attachDomEvents(dropdown: HTMLElement, focusable: HTMLElement, menu: HT
290290
}, true);
291291
}
292292

293+
// Although Fomantic Dropdown supports "hideDividers", it doesn't really work with our "scoped dividers"
294+
// At the moment, "label dropdown items" use scopes, a sample case is:
295+
// * a-label
296+
// * divider
297+
// * scope/1
298+
// * scope/2
299+
// * divider
300+
// * z-label
301+
// when the "scope/*" are filtered out, we'd like to see "a-label" and "z-label" without the divider.
293302
export function hideScopedEmptyDividers(container: Element) {
294303
const visibleItems: Element[] = [];
295304
const curScopeVisibleItems: Element[] = [];

0 commit comments

Comments
 (0)