Use COALESCE to make sure nulls are last regardless of DB.

telackey · telackey · commit 25c071852e98 · 2025-04-03T23:08:14.000-05:00
diff --git a/models/issues/issue_search.go b/models/issues/issue_search.go
@@ -77,7 +77,8 @@ func applySorts(sess *xorm.Session, sortType string, priorityRepoID int64) {
 		scope := strings.TrimPrefix(sortType, ScopeSortPrefix)
 		sess.Join("LEFT", "issue_label", "issue.id = issue_label.issue_id")
 		sess.Join("LEFT", "label", "label.id = issue_label.label_id and label.name LIKE ?", scope+"/%")
-		sess.Asc("label.exclusive_order").Desc("issue.id")
+		// 9223372036854775807 == max bigint
+		sess.OrderBy("COALESCE(label.exclusive_order, 9223372036854775807) ASC").Desc("issue.id")
 		return
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,8 @@ func applySorts(sess *xorm.Session, sortType string, priorityRepoID int64) {`
`77`	`77`	`scope := strings.TrimPrefix(sortType, ScopeSortPrefix)`
`78`	`78`	`sess.Join("LEFT", "issue_label", "issue.id = issue_label.issue_id")`
`79`	`79`	`sess.Join("LEFT", "label", "label.id = issue_label.label_id and label.name LIKE ?", scope+"/%")`
`80`		`- sess.Asc("label.exclusive_order").Desc("issue.id")`
	`80`	`+ // 9223372036854775807 == max bigint`
	`81`	`+ sess.OrderBy("COALESCE(label.exclusive_order, 9223372036854775807) ASC").Desc("issue.id")`
`81`	`82`	`return`
`82`	`83`	`}`
`83`	`84`