fix

Author: wxiaoguang

templates/repo/view_file.tmpl

@@ -114,7 +114,7 @@
 					{{end}}
 				</div>
 			{{else if .FileSize}}
-				<table data-global-init="initRepoCodeView">
+				<table>
 					<tbody>
 						{{range $idx, $code := .FileContent}}
 						{{$line := Eval $idx "+" 1}}

web_src/css/repo/file-view.css

@@ -1,7 +1,10 @@
-.file-view tr.active {
+.file-view tr.active .lines-num,
+.file-view tr.active .lines-escape,
+.file-view tr.active .lines-code {
   background: var(--color-highlight-bg);
 }
 
+/* set correct border radius on the last active lines, to avoid border overflow */
 .file-view tr.active:last-of-type .lines-code {
   border-bottom-right-radius: var(--border-radius);
 }
@@ -10,6 +13,7 @@
   position: relative;
 }
 
+/* add a darker "handler" at the beginning of the active line */
 .file-view tr.active .lines-num::before {
   content: "";
   position: absolute;

web_src/js/features/repo-code.ts

@@ -2,7 +2,6 @@ import {svg} from '../svg.ts';
 import {createTippy} from '../modules/tippy.ts';
 import {toAbsoluteUrl} from '../utils.ts';
 import {addDelegatedEventListener} from '../utils/dom.ts';
-import {registerGlobalInitFunc} from '../modules/observer.ts';
 
 function changeHash(hash: string) {
   if (window.history.pushState) {
@@ -111,25 +110,26 @@ function showLineButton() {
 }
 
 export function initRepoCodeView() {
-  registerGlobalInitFunc('initRepoCodeView', (el: HTMLElement) => {
-    if (!el.querySelector('.lines-num')) return;
-
-    let selRangeStart: string;
-    addDelegatedEventListener(el, 'click', '.lines-num span', (el: HTMLElement, e: KeyboardEvent) => {
-      if (!selRangeStart || !e.shiftKey) {
-        selRangeStart = el.getAttribute('id');
-        selectRange(selRangeStart);
-      } else {
-        const selRangeStop = el.getAttribute('id');
-        selectRange(`${selRangeStart}-${selRangeStop}`);
-      }
-      window.getSelection().removeAllRanges();
-      showLineButton();
-    });
+  if (!document.querySelector('.file-view.code-view')) return;
+
+  // "file code view" and "blame" pages need this "line number button" feature
+  let selRangeStart: string;
+  addDelegatedEventListener(document, 'click', '.code-view .lines-num span', (el: HTMLElement, e: KeyboardEvent) => {
+    if (!selRangeStart || !e.shiftKey) {
+      selRangeStart = el.getAttribute('id');
+      selectRange(selRangeStart);
+    } else {
+      const selRangeStop = el.getAttribute('id');
+      selectRange(`${selRangeStart}-${selRangeStop}`);
+    }
+    window.getSelection().removeAllRanges();
+    showLineButton();
   });
 
+  // apply the selected range from the URL hash
   const onHashChange = () => {
     if (!window.location.hash) return;
+    if (!document.querySelector('.code-view .lines-num')) return;
     const range = window.location.hash.substring(1);
     const first = selectRange(range);
     if (first) {