use MakeAbsoluteURL

Author: ChristopherHX

services/convert/convert.go

@@ -7,6 +7,7 @@ package convert
 import (
 	"context"
 	"fmt"
+	"net/url"
 	"strconv"
 	"strings"
 	"time"
@@ -24,6 +25,7 @@ import (
 	user_model "code.gitea.io/gitea/models/user"
 	"code.gitea.io/gitea/modules/container"
 	"code.gitea.io/gitea/modules/git"
+	"code.gitea.io/gitea/modules/httplib"
 	"code.gitea.io/gitea/modules/log"
 	"code.gitea.io/gitea/modules/setting"
 	api "code.gitea.io/gitea/modules/structs"
@@ -231,7 +233,7 @@ func ToActionTask(ctx context.Context, t *actions_model.ActionTask) (*api.Action
 
 // ToActionArtifact convert a actions_model.ActionArtifact to an api.ActionArtifact
 func ToActionArtifact(ctx context.Context, repoName string, art *actions_model.ActionArtifact) (*api.ActionArtifact, error) {
-	url := strings.TrimSuffix(setting.AppURL, "/") + "/api/v1/repos/" + repoName + "/actions/artifacts/" + fmt.Sprintf("%d", art.ID)
+	url := httplib.MakeAbsoluteURL(ctx, setting.AppSubURL+"/api/v1/repos/"+url.PathEscape(repoName)+"/actions/artifacts/"+fmt.Sprintf("%d", art.ID))
 
 	return &api.ActionArtifact{
 		ID:                 art.ID,