API: Fix null pointer in attempt to Sudo if not logged in (#5872) (#5884)

zeripath · web-flow · commit 29799537a76f · 2019-01-28T20:26:55.000Z
Backport of #5872 to v1.7 Signed-off-by: Andrew Thornton <art27@cantab.net>
diff --git a/routers/api/v1/api.go b/routers/api/v1/api.go
@@ -85,7 +85,7 @@ func sudo() macaron.Handler {
 		}
 
 		if len(sudo) > 0 {
-			if ctx.User.IsAdmin {
+			if ctx.IsSigned && ctx.User.IsAdmin {
 				user, err := models.GetUserByName(sudo)
 				if err != nil {
 					if models.IsErrUserNotExist(err) {

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ func sudo() macaron.Handler {`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`if len(sudo) > 0 {`
`88`		`- if ctx.User.IsAdmin {`
	`88`	`+ if ctx.IsSigned && ctx.User.IsAdmin {`
`89`	`89`	`user, err := models.GetUserByName(sudo)`
`90`	`90`	`if err != nil {`
`91`	`91`	`if models.IsErrUserNotExist(err) {`