Fix tests

Author: lunny

models/git/commit_status_test.go

@@ -124,7 +124,7 @@ func Test_CalcCommitStatus(t *testing.T) {
 				},
 			},
 			expected: &git_model.CommitStatus{
-				State: commitstatus.CommitStatusError,
+				State: commitstatus.CommitStatusFailure,
 			},
 		},
 		{
@@ -140,7 +140,7 @@ func Test_CalcCommitStatus(t *testing.T) {
 				},
 			},
 			expected: &git_model.CommitStatus{
-				State: commitstatus.CommitStatusWarning,
+				State: commitstatus.CommitStatusSuccess,
 			},
 		},
 		{
@@ -172,7 +172,7 @@ func Test_CalcCommitStatus(t *testing.T) {
 				},
 			},
 			expected: &git_model.CommitStatus{
-				State: commitstatus.CommitStatusError,
+				State: commitstatus.CommitStatusFailure,
 			},
 		},
 	}

services/pull/commit_status.go

@@ -20,6 +20,10 @@ import (
 
 // MergeRequiredContextsCommitStatus returns a commit status state for given required contexts
 func MergeRequiredContextsCommitStatus(commitStatuses []*git_model.CommitStatus, requiredContexts []string) commitstatus.CommitStatusState {
+	if len(commitStatuses) == 0 {
+		return commitstatus.CommitStatusPending
+	}
+
 	if len(requiredContexts) == 0 {
 		return git_model.CalcCommitStatus(commitStatuses).State
 	}