Add context param

Author: hiifong

models/actions/run_list.go

@@ -134,6 +134,6 @@ func GetActors(ctx context.Context, repoID int64) ([]*user_model.User, error) {
 		GroupBy("`action_run`.trigger_user_id").
 		Where(builder.Eq{"`action_run`.repo_id": repoID}))).
 		Cols("id", "name", "full_name", "avatar", "avatar_email", "use_custom_avatar").
-		OrderBy(user_model.GetOrderByName()).
+		OrderBy(user_model.GetOrderByName(ctx)).
 		Find(&actors)
 }

models/issues/issue_list.go

@@ -251,7 +251,7 @@ func (issues IssueList) LoadAssignees(ctx context.Context) error {
 		}
 		rows, err := db.GetEngine(ctx).Table("issue_assignees").
 			Join("INNER", "`user`", "`user`.id = `issue_assignees`.assignee_id").
-			In("`issue_assignees`.issue_id", issueIDs[:limit]).OrderBy(user_model.GetOrderByName()).
+			In("`issue_assignees`.issue_id", issueIDs[:limit]).OrderBy(user_model.GetOrderByName(ctx)).
 			Rows(new(AssigneeIssue))
 		if err != nil {
 			return err

models/issues/reaction.go

@@ -355,9 +355,9 @@ func (list ReactionList) LoadUsers(ctx context.Context, repo *repo_model.Reposit
 }
 
 // GetFirstUsers returns first reacted user display names separated by comma
-func (list ReactionList) GetFirstUsers() string {
+func (list ReactionList) GetFirstUsers(ctx context.Context) string {
 	var buffer bytes.Buffer
-	rem := setting.Config().UI.ReactionMaxUserNum.Value(context.Background())
+	rem := setting.Config().UI.ReactionMaxUserNum.Value(ctx)
 	for _, reaction := range list {
 		if buffer.Len() > 0 {
 			buffer.WriteString(", ")
@@ -371,8 +371,7 @@ func (list ReactionList) GetFirstUsers() string {
 }
 
 // GetMoreUserCount returns count of not shown users in reaction tooltip
-func (list ReactionList) GetMoreUserCount() int {
-	ctx := context.Background()
+func (list ReactionList) GetMoreUserCount(ctx context.Context) int {
 	if len(list) <= setting.Config().UI.ReactionMaxUserNum.Value(ctx) {
 		return 0
 	}

models/organization/org.go

@@ -169,8 +169,8 @@ func (org *Organization) OrganisationLink() string {
 }
 
 // ShortName ellipses username to length
-func (org *Organization) ShortName(length int) string {
-	return org.AsUser().ShortName(length)
+func (org *Organization) ShortName(ctx context.Context, length int) string {
+	return org.AsUser().ShortName(ctx, length)
 }
 
 // HomeLink returns the user or organization home page link.

models/organization/org_user.go

@@ -163,7 +163,7 @@ func GetOrgAssignees(ctx context.Context, orgID int64) (_ []*user_model.User, er
 	if len(userIDs) > 0 {
 		if err = e.In("id", uniqueUserIDs.Values()).
 			Where(builder.Eq{"`user`.is_active": true}).
-			OrderBy(user_model.GetOrderByName()).
+			OrderBy(user_model.GetOrderByName(ctx)).
 			Find(&users); err != nil {
 			return nil, err
 		}

models/repo/user_repo.go

@@ -134,7 +134,7 @@ func GetRepoAssignees(ctx context.Context, repo *Repository) (_ []*user_model.Us
 	if len(uniqueUserIDs) > 0 {
 		if err = e.In("id", uniqueUserIDs.Values()).
 			Where(builder.Eq{"`user`.is_active": true}).
-			OrderBy(user_model.GetOrderByName()).
+			OrderBy(user_model.GetOrderByName(ctx)).
 			Find(&users); err != nil {
 			return nil, err
 		}

models/user/user.go

@@ -440,8 +440,8 @@ func (u *User) EmailTo() string {
 
 // GetDisplayName returns full name if it's not empty and DEFAULT_SHOW_FULL_NAME is set,
 // returns username otherwise.
-func (u *User) GetDisplayName() string {
-	if setting.Config().UI.DefaultShowFullName.Value(context.Background()) {
+func (u *User) GetDisplayName(ctx context.Context) string {
+	if setting.Config().UI.DefaultShowFullName.Value(ctx) {
 		trimmed := strings.TrimSpace(u.FullName)
 		if len(trimmed) > 0 {
 			return trimmed
@@ -482,8 +482,8 @@ func (u *User) GitName() string {
 }
 
 // ShortName ellipses username to length
-func (u *User) ShortName(length int) string {
-	if setting.Config().UI.DefaultShowFullName.Value(context.Background()) && len(u.FullName) > 0 {
+func (u *User) ShortName(ctx context.Context, length int) string {
+	if setting.Config().UI.DefaultShowFullName.Value(ctx) && len(u.FullName) > 0 {
 		return util.EllipsisDisplayString(u.FullName, length)
 	}
 	return util.EllipsisDisplayString(u.Name, length)
@@ -1393,8 +1393,8 @@ func FixWrongUserType(ctx context.Context) (int64, error) {
 	return db.GetEngine(ctx).Where(builder.Eq{"type": 0}.And(builder.Neq{"num_teams": 0})).Cols("type").NoAutoTime().Update(&User{Type: 1})
 }
 
-func GetOrderByName() string {
-	if setting.Config().UI.DefaultShowFullName.Value(context.Background()) {
+func GetOrderByName(ctx context.Context) string {
+	if setting.Config().UI.DefaultShowFullName.Value(ctx) {
 		return "full_name, name"
 	}
 	return "name"

modules/charset/escape.go

@@ -22,15 +22,15 @@ import (
 const RuneNBSP = 0xa0
 
 // EscapeControlHTML escapes the unicode control sequences in a provided html document
-func EscapeControlHTML(html template.HTML, locale translation.Locale, allowed ...rune) (escaped *EscapeStatus, output template.HTML) {
+func EscapeControlHTML(ctx context.Context, html template.HTML, locale translation.Locale, allowed ...rune) (escaped *EscapeStatus, output template.HTML) {
 	sb := &strings.Builder{}
-	escaped, _ = EscapeControlReader(strings.NewReader(string(html)), sb, locale, allowed...) // err has been handled in EscapeControlReader
+	escaped, _ = EscapeControlReader(ctx, strings.NewReader(string(html)), sb, locale, allowed...) // err has been handled in EscapeControlReader
 	return escaped, template.HTML(sb.String())
 }
 
 // EscapeControlReader escapes the unicode control sequences in a provided reader of HTML content and writer in a locale and returns the findings as an EscapeStatus
-func EscapeControlReader(reader io.Reader, writer io.Writer, locale translation.Locale, allowed ...rune) (escaped *EscapeStatus, err error) {
-	if !setting.Config().UI.AmbiguousUnicodeDetection.Value(context.Background()) {
+func EscapeControlReader(ctx context.Context, reader io.Reader, writer io.Writer, locale translation.Locale, allowed ...rune) (escaped *EscapeStatus, err error) {
+	if !setting.Config().UI.AmbiguousUnicodeDetection.Value(ctx) {
 		_, err = io.Copy(writer, reader)
 		return &EscapeStatus{}, err
 	}

modules/charset/escape_test.go

@@ -162,7 +162,7 @@ func TestEscapeControlReader(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			output := &strings.Builder{}
-			status, err := EscapeControlReader(strings.NewReader(tt.text), output, &translation.MockLocale{})
+			status, err := EscapeControlReader(t.Context(), strings.NewReader(tt.text), output, &translation.MockLocale{})
 			assert.NoError(t, err)
 			assert.Equal(t, tt.status, *status)
 			outStr := output.String()
@@ -175,10 +175,10 @@ func TestEscapeControlReader(t *testing.T) {
 func TestSettingAmbiguousUnicodeDetection(t *testing.T) {
 	ambiguousUnicodeDetectionValue := setting.Config().UI.AmbiguousUnicodeDetection.Value(t.Context())
 	defer test.MockVariableValue(&ambiguousUnicodeDetectionValue, true)()
-	_, out := EscapeControlHTML("a test", &translation.MockLocale{})
+	_, out := EscapeControlHTML(t.Context(), "a test", &translation.MockLocale{})
 	assert.EqualValues(t, `a<span class="escaped-code-point" data-escaped="[U+00A0]"><span class="char"> </span></span>test`, out)
 	ambiguousUnicodeDetection := config.Value[bool]{}
 	setting.Config().UI.AmbiguousUnicodeDetection = ambiguousUnicodeDetection.WithDefault(false)
-	_, out = EscapeControlHTML("a test", &translation.MockLocale{})
+	_, out = EscapeControlHTML(t.Context(), "a test", &translation.MockLocale{})
 	assert.EqualValues(t, `a test`, out)
 }

modules/issue/template/unmarshal.go

@@ -43,31 +43,31 @@ func Unmarshal(filename string, content []byte) (*api.IssueTemplate, error) {
 }
 
 // UnmarshalFromEntry parses out a valid template from the blob in entry
-func UnmarshalFromEntry(entry *git.TreeEntry, dir string) (*api.IssueTemplate, error) {
-	return unmarshalFromEntry(entry, path.Join(dir, entry.Name())) // Filepaths in Git are ALWAYS '/' separated do not use filepath here
+func UnmarshalFromEntry(ctx context.Context, entry *git.TreeEntry, dir string) (*api.IssueTemplate, error) {
+	return unmarshalFromEntry(ctx, entry, path.Join(dir, entry.Name())) // Filepaths in Git are ALWAYS '/' separated do not use filepath here
 }
 
 // UnmarshalFromCommit parses out a valid template from the commit
-func UnmarshalFromCommit(commit *git.Commit, filename string) (*api.IssueTemplate, error) {
+func UnmarshalFromCommit(ctx context.Context, commit *git.Commit, filename string) (*api.IssueTemplate, error) {
 	entry, err := commit.GetTreeEntryByPath(filename)
 	if err != nil {
 		return nil, fmt.Errorf("get entry for %q: %w", filename, err)
 	}
-	return unmarshalFromEntry(entry, filename)
+	return unmarshalFromEntry(ctx, entry, filename)
 }
 
 // UnmarshalFromRepo parses out a valid template from the head commit of the branch
-func UnmarshalFromRepo(repo *git.Repository, branch, filename string) (*api.IssueTemplate, error) {
+func UnmarshalFromRepo(ctx context.Context, repo *git.Repository, branch, filename string) (*api.IssueTemplate, error) {
 	commit, err := repo.GetBranchCommit(branch)
 	if err != nil {
 		return nil, fmt.Errorf("get commit on branch %q: %w", branch, err)
 	}
 
-	return UnmarshalFromCommit(commit, filename)
+	return UnmarshalFromCommit(ctx, commit, filename)
 }
 
-func unmarshalFromEntry(entry *git.TreeEntry, filename string) (*api.IssueTemplate, error) {
-	if size := entry.Blob().Size(); size > setting.Config().UI.MaxDisplayFileSize.Value(context.Background()) {
+func unmarshalFromEntry(ctx context.Context, entry *git.TreeEntry, filename string) (*api.IssueTemplate, error) {
+	if size := entry.Blob().Size(); size > setting.Config().UI.MaxDisplayFileSize.Value(ctx) {
 		return nil, fmt.Errorf("too large: %v > MaxDisplayFileSize", size)
 	}