Clean up code to address review comments

Author: McRaeAlex

routers/web/repo/treelist.go

@@ -59,7 +59,6 @@ type FileDiffFile struct {
 	Name        string
 	NameHash    string
 	IsSubmodule bool
-	IsBinary    bool
 	IsViewed    bool
 	Status      string
 }
@@ -72,18 +71,12 @@ func transformDiffTreeForUI(diffTree *gitdiff.DiffTree, filesViewedState map[str
 	for _, file := range diffTree.Files {
 		nameHash := git.HashFilePathForWebUI(file.HeadPath)
 		isSubmodule := file.HeadMode == git.EntryModeCommit
-		isBinary := file.HeadMode == git.EntryModeExec
-
-		isViewed := false
-		if fileViewedState, ok := filesViewedState[file.Path()]; ok {
-			isViewed = (fileViewedState == pull_model.Viewed)
-		}
+		isViewed := filesViewedState[file.Path()] == pull_model.Viewed
 
 		files = append(files, FileDiffFile{
 			Name:        file.HeadPath,
 			NameHash:    nameHash,
 			IsSubmodule: isSubmodule,
-			IsBinary:    isBinary,
 			IsViewed:    isViewed,
 			Status:      file.Status,
 		})

templates/repo/diff/box.tmpl

@@ -60,18 +60,13 @@
 		<script id="diff-data-script" type="module">
 			const diffDataFiles = [{{range $i, $file := .DiffFiles}}
 				{Name:"{{$file.Name}}",NameHash:"{{$file.NameHash}}",Status:{{$file.Status}},IsSubmodule:{{$file.IsSubmodule}},IsViewed:{{$file.IsViewed}}},{{end}}];
+
 			const diffData = {
 				isIncomplete: {{.Diff.IsIncomplete}},
-				tooManyFilesMessage: "{{ctx.Locale.Tr "repo.diff.too_many_files"}}",
-				binaryFileMessage: "{{ctx.Locale.Tr "repo.diff.bin"}}",
-				showMoreMessage: "{{ctx.Locale.Tr "repo.diff.show_more"}}",
-				statisticsMessage: "{{ctx.Locale.Tr "repo.diff.stats_desc_file"}}",
-				linkLoadMore: "?skip-to={{.Diff.End}}&file-only=true",
 			};
 
 			// for first time loading, the diffFileInfo is a plain object
 			// after the Vue component is mounted, the diffFileInfo is a reactive object
-			// keep in mind that this script block would be executed many times when loading more files, by "loadMoreFiles"
 			let diffFileInfo = window.config.pageData.diffFileInfo || {
 				files:[],
 				fileTreeIsVisible: false,