fix

Author: wxiaoguang

models/user/user.go

@@ -831,16 +831,17 @@ type CountUserFilter struct {
 	IsActive       optional.Option[bool]
 }
 
-// HasUsers returns true if any user exists in the database.
-// It performs a much more efficient check than counting all users.
-func HasUsers(ctx context.Context) (bool, error) {
-	sess := db.GetEngine(ctx)
-	exists, err := sess.Exist(new(User))
+// HasUsers checks whether there are any users in the database, or only one user exists.
+func HasUsers(ctx context.Context) (ret struct {
+	HasAnyUser, HasOnlyOneUser bool
+}, err error) {
+	res, err := db.GetEngine(ctx).Table(&User{}).Cols("id").Limit(2).Query()
 	if err != nil {
-		return false, fmt.Errorf("error checking user existence: %w", err)
+		return ret, fmt.Errorf("error checking user existence: %w", err)
 	}
-
-	return exists, nil
+	ret.HasAnyUser = len(res) != 0
+	ret.HasOnlyOneUser = len(res) == 1
+	return ret, nil
 }
 
 // CountUsers returns number of users.

routers/install/install.go

@@ -608,6 +608,6 @@ func SubmitInstall(ctx *context.Context) {
 // The name is not called as "PostInstall" to avoid misinterpretation as a handler for "POST /install"
 func InstallDone(ctx *context.Context) { //nolint
 	hasUsers, _ := user_model.HasUsers(ctx)
-	ctx.Data["IsAccountCreated"] = hasUsers
+	ctx.Data["IsAccountCreated"] = hasUsers.HasAnyUser
 	ctx.HTML(http.StatusOK, tplPostInstall)
 }

routers/web/auth/auth.go

@@ -421,12 +421,10 @@ func SignOut(ctx *context.Context) {
 // SignUp render the register page
 func SignUp(ctx *context.Context) {
 	ctx.Data["Title"] = ctx.Tr("sign_up")
-
 	ctx.Data["SignUpLink"] = setting.AppSubURL + "/user/sign_up"
 
 	hasUsers, _ := user_model.HasUsers(ctx)
-
-	ctx.Data["IsFirstTimeRegistration"] = !hasUsers
+	ctx.Data["IsFirstTimeRegistration"] = !hasUsers.HasAnyUser
 
 	oauth2Providers, err := oauth2.GetOAuth2Providers(ctx, optional.Some(true))
 	if err != nil {
@@ -614,7 +612,13 @@ func createUserInContext(ctx *context.Context, tpl templates.TplName, form any,
 // sends a confirmation email if required.
 func handleUserCreated(ctx *context.Context, u *user_model.User, gothUser *goth.User) (ok bool) {
 	// Auto-set admin for the only user.
-	if user_model.CountUsers(ctx, nil) == 1 {
+	hasUsers, err := user_model.HasUsers(ctx)
+	if err != nil {
+		ctx.ServerError("HasUsers", err)
+		return false
+	}
+	if hasUsers.HasOnlyOneUser {
+		// the only user is the one just created, will set it as admin
 		opts := &user_service.UpdateOptions{
 			IsActive:     optional.Some(true),
 			IsAdmin:      optional.Some(true),