Check if Pull + run linter

Author: splitt3r

routers/web/repo/issue.go

@@ -1219,28 +1219,30 @@ func ValidateRepoMetas(ctx *context.Context, form forms.CreateIssueForm, isPull
 
 	// Check reviewers
 	var reviewerIDs []int64
-	if len(form.ReviewerIDs) > 0 {
-		reviewerIDs, err = base.StringsToInt64s(strings.Split(form.ReviewerIDs, ","))
-		if err != nil {
-			return nil, nil, nil, 0, 0
-		}
+	if isPull {
+		if len(form.ReviewerIDs) > 0 {
+			reviewerIDs, err = base.StringsToInt64s(strings.Split(form.ReviewerIDs, ","))
+			if err != nil {
+				return nil, nil, nil, 0, 0
+			}
 
-		// Check if the passed reviewers (user/team) actually exist
-		for _, rID := range reviewerIDs {
-			// negative reviewIDs represent team requests
-			if rID < 0 {
-				_, err := organization.GetTeamByID(ctx, -rID)
+			// Check if the passed reviewers (user/team) actually exist
+			for _, rID := range reviewerIDs {
+				// negative reviewIDs represent team requests
+				if rID < 0 {
+					_, err := organization.GetTeamByID(ctx, -rID)
+					if err != nil {
+						ctx.ServerError("GetTeamByID", err)
+						return nil, nil, nil, 0, 0
+					}
+					continue
+				}
+
+				_, err := user_model.GetUserByID(ctx, rID)
 				if err != nil {
-					ctx.ServerError("GetTeamByID", err)
+					ctx.ServerError("GetUserByID", err)
 					return nil, nil, nil, 0, 0
 				}
-				continue
-			}
-
-			_, err := user_model.GetUserByID(ctx, rID)
-			if err != nil {
-				ctx.ServerError("GetUserByID", err)
-				return nil, nil, nil, 0, 0
 			}
 		}
 	}

services/pull/pull.go

@@ -43,7 +43,7 @@ func getPullWorkingLockKey(prID int64) string {
 }
 
 // NewPullRequest creates new pull request with labels for repository.
-func NewPullRequest(ctx context.Context, repo *repo_model.Repository, issue *issues_model.Issue, labelIDs []int64, uuids []string, pr *issues_model.PullRequest, assigneeIDs []int64, reviewerIDs []int64) error {
+func NewPullRequest(ctx context.Context, repo *repo_model.Repository, issue *issues_model.Issue, labelIDs []int64, uuids []string, pr *issues_model.PullRequest, assigneeIDs, reviewerIDs []int64) error {
 	if err := issue.LoadPoster(ctx); err != nil {
 		return err
 	}