Fix oauth2 error handle not return immediately (#32514)

lunny · web-flow · commit 4121f952d18a · 2024-11-15T02:13:01.000Z
diff --git a/routers/web/auth/oauth.go b/routers/web/auth/oauth.go
@@ -122,6 +122,8 @@ func SignInOAuthCallback(ctx *context.Context) {
 		}
 		if err, ok := err.(*go_oauth2.RetrieveError); ok {
 			ctx.Flash.Error("OAuth2 RetrieveError: "+err.Error(), true)
+			ctx.Redirect(setting.AppSubURL + "/user/login")
+			return
 		}
 		ctx.ServerError("UserSignIn", err)
 		return

Original file line number	Diff line number	Diff line change
`@@ -122,6 +122,8 @@ func SignInOAuthCallback(ctx *context.Context) {`
`122`	`122`	`}`
`123`	`123`	`if err, ok := err.(*go_oauth2.RetrieveError); ok {`
`124`	`124`	`ctx.Flash.Error("OAuth2 RetrieveError: "+err.Error(), true)`
	`125`	`+ ctx.Redirect(setting.AppSubURL + "/user/login")`
	`126`	`+ return`
`125`	`127`	`}`
`126`	`128`	`ctx.ServerError("UserSignIn", err)`
`127`	`129`	`return`